Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Prefix library attributes #4

Closed
hvisser opened this issue Sep 11, 2016 · 2 comments
Closed

Prefix library attributes #4

hvisser opened this issue Sep 11, 2016 · 2 comments

Comments

@hvisser
Copy link

hvisser commented Sep 11, 2016

Because android attributes are shared in a common namespace, it's a good habit to prefix attributes like aspectRatio in order to prevent conflicts with other libraries that a project may use.

I'd suggest prefixing the attributes this library adds with cam or cv for example so that app:aspectRatio would become app:camAspectRatio or app:cvAspectRatio.

@chrisbanes
Copy link

chrisbanes commented Sep 16, 2016

Because android attributes are currently shared in a common namespace

We should leave this as-is, its a Tools problem and is being fixed from there.

@hvisser
Copy link
Author

hvisser commented Sep 17, 2016

I'm not sure how far we are from aapt2 being a thing, but I can live with that :) Filed this mainly on my experience with other libs that had clashing attributes, which is a painful experience, so I'll close this then.

@hvisser hvisser closed this as completed Sep 17, 2016
@yaraki yaraki mentioned this issue Sep 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants