Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider how to handle camino::Utf8PathBuf #421

Closed
illicitonion opened this issue May 27, 2021 · 0 comments · Fixed by #511
Closed

Consider how to handle camino::Utf8PathBuf #421

illicitonion opened this issue May 27, 2021 · 0 comments · Fixed by #511

Comments

@illicitonion
Copy link
Collaborator

oli-obk/cargo_metadata#152 updated cargo_metadata to use camino::Utf8PathBuf instead of std::path::PathBuf. The idea is that, as cargo only supports UTF-8 paths, this simplifies some handling (e.g. Utf8PathBuf can impl Display, rather than needing .to_string_lossy() and .display() calls)

We should work out whether we want to treat this as a localised change in that API (converting back to PathBuf/Path on the boundary with cargo_metadata), or whether we want to adopt Utf8PathBuf ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant