Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename com_github_antlr_antlr4_runtime_go_antlr to com_github_antlr_antlr4_runtime_go_antlr_v4 #680

Closed
satreix opened this issue Apr 10, 2023 · 1 comment · Fixed by #691

Comments

@satreix
Copy link

satreix commented Apr 10, 2023

Describe the bug

Recent version of gazelle map "github.com/antlr/antlr4/runtime/Go/antlr/v4" to "com_github_antlr_antlr4_runtime_go_antlr_v4" and not "com_github_antlr_antlr4_runtime_go_antlr".

This causes the following error for projects that import cel-go with bazel and gazelle:

ERROR: external/com_github_google_cel_go/parser/BUILD.bazel:7:11: no such package '@com_github_antlr_antlr4_runtime_go_antlr//': The repository '@com_github_antlr_antlr4_runtime_go_antlr' could not be resolved: Repository '@com_github_antlr_antlr4_runtime_go_antlr' is not defined and referenced by '@com_github_google_cel_go//parser:go_default_library

To Reproduce

Use a recent version of go/bazel/gazelle and depend on cel-go v0.14. This is done in satreix/everest#466 (you do need to drop the patch introduced in the PR for the issue to trigger).

Expected behavior

Gazelle should not be tripped by the naming of com_github_antlr_antlr4_runtime_go_antlr in this repo.

Additional context
IIUC this was introduced with #644

@TristonianJones
Copy link
Collaborator

Thank you, @satreix. I'll make to bump the WORKSPACE naming and associated bzl files and create a point release mid-week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants