Bad logic in src/logs/Cert::ExtensionStructure()

[pphaneuf]

No description provided.

[pphaneuf]

Relevant code:

*ext_struct = X509_get_ext_d2i(x509_, extension_nid, &crit, NULL);

if (ext_struct == NULL) {
if (crit != -1) {
LOG(WARNING) << "Corrupt extension data";

The check "ext_struct == NULL" is invalid. (If it is NULL, the previous line would segfault.) Presumably this should be "*ext_struct == NULL".

What version of the product are you using? On what operating system?

Latest code at https://code.google.com/p/certificate-transparency/source/browse/src/log/cert.cc

[pphaneuf]

The fix is out for review in https://codereview.appspot.com/68190045

[pphaneuf]

Fixed in https://code.google.com/p/certificate-transparency/source/detail?r=dd00c6e4fd947ca905a74ead893803046c5de857