Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display breaks outside of vehicle [start, end]. #56

Closed
ghost opened this issue Feb 8, 2023 · 3 comments · Fixed by #63
Closed

Do not display breaks outside of vehicle [start, end]. #56

ghost opened this issue Feb 8, 2023 · 3 comments · Fixed by #63

Comments

@ghost
Copy link

ghost commented Feb 8, 2023

Vehicle breaks do not count towards costs if they are before vehicle start or after vehicle end.
The schedule part of the interface still displays them in those cases, and also display wait time between the vehicle time window and the "outside" break.

Instead, there should be no waiting time displayed, and outside breaks should either no be displayed or displayed suggesting the break is not performed, for instance in grey.

@jmccollum-woolpert
Copy link
Contributor

Thanks, opening up a PR to address. Is this functionality documented somewhere? Would be helpful to make it clear why these scheduled breaks are different.

@ghost
Copy link
Author

ghost commented Mar 9, 2023

It is not very explicit in the documentation: https://cloud.google.com/optimization/docs/reference/rpc/google.cloud.optimization.v1#breakrule
But breaks that before vehicle start time or after vehicle end time do not affect the solution, they can be ignored.

Thanks for your work! I use the interface a lot to visualize the effects of tweaks to routing models, it's extremely useful!

@jmccollum-woolpert
Copy link
Contributor

Got it, thanks for the clarification and glad you've been enjoying the application!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants