Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

[WEB] Could not compile with Flutter 3.0.0 #764

Open
bambinoua opened this issue May 12, 2022 · 12 comments
Open

[WEB] Could not compile with Flutter 3.0.0 #764

bambinoua opened this issue May 12, 2022 · 12 comments

Comments

@bambinoua
Copy link

At compilation process I see this message:

Warning: Operand of null-aware operation '!' has type 'SchedullerBinding' which excludes null.

SchedullerBinding.instance!.addPostFrameCallback(...)
                          ^
                          |---- Since flutter 3.0.0 instance does not nullable.
@federico2390
Copy link

Go to the relative file and remove the "!"

@andreclinio
Copy link

Any perspective from the authors about a patch release?

@federico2390
Copy link

I dont know but for now, this is a solution

@bambinoua
Copy link
Author

Go to the relative file and remove the "!"

Do you suggest to do this any time after update/upgrade packages?

P.S. I think the best solution is to clone repository and make a fix. Will wait for some anyway.

@viralkachhadiya
Copy link

viralkachhadiya commented May 14, 2022

@stuartmorgan can you look below pr?

@stuartmorgan
Copy link
Collaborator

@stuartmorgan can you look below pr?

Please see https://github.com/google/charts#development. I can look into the possibility of re-syncing changes though.

However, I'm not sure why the title of this issue is "could not compile" given that this is just a warning.

@bambinoua
Copy link
Author

However, I'm not sure why the title of this issue is "could not compile" given that this is just a warning.

Yes, you are right now it is a warning but when I wrote this message I have at least 3 packages with the same issue and web app was not compiled (it was stopped) so I notified all authors of problem packages.

Some packages were fixed so no this package just print warning so I think this issue can be closed.

@bambinoua bambinoua reopened this May 19, 2022
@bambinoua
Copy link
Author

No.. I think it will better to close it after this issue was fixed really. Sorry ;)

@viralkachhadiya
Copy link

@bambinoua can you please review or merge above pr?

@mathiuleo
Copy link

For me, I can clone the repository and modify the code.
But what I want is to respect the author's license, so I won't clone or copy code into our project :)

@purgeyao
Copy link

@bambinoua Anyway, there's a warning that needs to be tuned out. What are your plans

@trojancode
Copy link

Use this package.
https://pub.dev/packages/charts_flutter_new

It's a fixed version of charts_flutter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants