Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Switch away from PhantomJS #57

Closed
lavelle opened this issue Aug 29, 2014 · 1 comment · Fixed by #58
Closed

Switch away from PhantomJS #57

lavelle opened this issue Aug 29, 2014 · 1 comment · Fixed by #58

Comments

@lavelle
Copy link
Contributor

lavelle commented Aug 29, 2014

Currently all the unit tests run in PhantomJS. It works, but it's running a very old Webkit build, which means constantly polyfilling functions for it. So far in the project I have had to polyfill:

And if we want to use the new native ArrayBuffer to string conversion library we will need to Polyfill TextDecoder too.

It's a waste of time constantly trying to work out whether an error is due to a bug in the code or a missing feature in PhantomJS, so we should switch over to running the tests in Chrome, for a consistent environment. The best way to automate this seems to be Karma.

@lavelle
Copy link
Contributor Author

lavelle commented Aug 29, 2014

Looks like we will still have to use Firefox as Travis CI only supports that, not Chrome. This is still much better than PhantomJS though, and should have all these modern features we need.

@jmuk jmuk closed this as completed in #58 Aug 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant