Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there anyone who is working on "user customizable color scheme" ? #202

Open
0xPrateek opened this issue Jun 1, 2019 · 7 comments
Open
Assignees

Comments

@0xPrateek
Copy link

Hello,
I have looked up previous issues related to color schemes (#5, #15 ) but I think i have better color scheme implementation idea which will enhance the UI of the editor.

@dschuyler
Copy link
Collaborator

Not that I'm aware of. It's an area that needs some attention.

Note: While looking at the code referenced below, you may start to wonder "how does this work?": the answer is that it doesn't. The current code is a mix of two versions of handling colors that haven't been cleaned up/fixed. What follows is a description of how it was intended to work, but doesn't currently work.

Code:
The color scheme stuff is in ci_edit/app/default_prefs.py, roughly lines 100-300 and lines 1180-1220. (or search for 'color8 = ' and ' "palette":').

The (intended) way for a user to change the color scheme (to "dark" for example) is to edit
"~/.ci_edit/prefs/editor.json" with text like:

{
        "colorScheme": "dark"
}

That is (or should, if it wasn't broken) be handled in ci_edit/app/ci_program.py within setUpPalette(self).

There's also an option to specify
"~/.ci_edit/prefs/editor.json":

{
        "colorScheme": "custom"
}

and provide a custom palette in "~/.ci_edit/prefs/color_scheme.json".

@dschuyler
Copy link
Collaborator

Would you like me to fix the current color design or are you thinking of reworking the code so much that fixing the existing code wouldn't help?

@0xPrateek
Copy link
Author

Actually, I have thought a couple of ways to change the color scheme. You have explained the current color scheme implementation very well and now I can better think on my implementation method (Thanks.. :) )

  • How the user will be able to change the color scheme
    1 - By using some shortcut keys; like we have ctrl+s for saving. we can also have some specific keys related to some default color scheme and thus the user can change the color scheme directly from the terminal just it will reload the editor once.
    2- The second method is by creating a configuration file specifically for the custom color scheme which will be a script and it does what you said that it should do manually.
    we can choose either of the ways.. 👍

@0xPrateek
Copy link
Author

I just want to know that if that feature of changing the color scheme is not UP and you aren't working on it then can i work on to improve ci_edit?

@dschuyler
Copy link
Collaborator

I'll assign this bug to you to show that you're working on it.

@0xPrateek
Copy link
Author

Great ..!

@seasonedfish
Copy link

Any progress on this? I would love to have dark themes so that opening the editor in a dark-themed terminal would not be so jarring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants