Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.claspignore does not handle ./ and ../ in paths #617

Closed
PopGoesTheWza opened this issue May 15, 2019 · 3 comments · Fixed by #620
Closed

.claspignore does not handle ./ and ../ in paths #617

PopGoesTheWza opened this issue May 15, 2019 · 3 comments · Fixed by #620

Comments

@PopGoesTheWza
Copy link
Collaborator

If the rootDir in the .clasp.json happens to contain ./ or ../ the .claspignore patterns fails to match anything.

This is in fact an issue within the multimatch module

Expected Behavior

n.a.

Actual Behavior

n.a.

Steps to Reproduce the Problem

Specifications

  • Node version (node -v): 10
  • Version (clasp -v): latest
  • OS (Mac/Linux/Windows): Mac
@PopGoesTheWza
Copy link
Collaborator Author

For reference: sindresorhus/multimatch#29

@grant
Copy link
Contributor

grant commented May 15, 2019

We should probably use glob to match files.

See:
#58
#86

This was referenced May 16, 2019
Closed
Merged
@PopGoesTheWza
Copy link
Collaborator Author

No need for ‘glob’ in fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relative rootdir PopGoesTheWza/clasp
(WIP) Glob match PopGoesTheWza/clasp
2 participants
@grant @PopGoesTheWza