Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/commands are not tested on CI #793

Closed
tricknotes opened this issue Jul 15, 2020 · 2 comments · Fixed by #794
Closed

test/commands are not tested on CI #793

tricknotes opened this issue Jul 15, 2020 · 2 comments · Fixed by #794

Comments

@tricknotes
Copy link
Contributor

Since 3a1948c, tests under tests/commands are not tested via $ npm run test.
The following diff enables tests, but it seems there are some failing tests...

diff --git a/package.json b/package.json
index a361c3b..e81134d 100644
--- a/package.json
+++ b/package.json
@@ -10,7 +10,7 @@
     "prepare": "npm run compile",
     "publish": "npm publish --access public",
     "lint": "npm run check",
-    "test": "nyc mocha --cache false --timeout 100000 build/test",
+    "test": "nyc mocha --cache false --timeout 100000 build/test/*.js build/test/**/*.js",
     "coverage": "nyc --cache false report --reporter=text-lcov | coveralls",
     "prettier": "prettier src test --write",
     "check": "gts check src/*.ts src/**/*.ts test/*.ts test/**/*.ts",
@PopGoesTheWza
Copy link
Collaborator

Good pick. Do you rather feel like opening another PR or include it in #789 ?

If when reenabling ignored tests, it reveals that some were broken, a separate PR is probably best.

My guess if that the entire test suite should be revisited, probably refactored, but it is not my strongest point.

@tricknotes
Copy link
Contributor Author

Thanks for your comment, @PopGoesTheWza
I'll make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants