Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js closureCompiler.run() signature is wrong in README #94

Closed
leeoniya opened this issue Jul 18, 2018 · 2 comments
Closed

js closureCompiler.run() signature is wrong in README #94

leeoniya opened this issue Jul 18, 2018 · 2 comments

Comments

@leeoniya
Copy link

leeoniya commented Jul 18, 2018

hey @ChadKillingsworth,

const compilerProcess = closureCompiler.run(function(exitCode, stdOut, stdErr) {
  //compilation complete
}, [{
 path: 'file-one.js',
 src: 'alert("hello world")',
 sourceMap: null // optional input source map
}]);

this should be run(fileList, callback) [1] ... and the return value is the compilation artifact out.

i can confirm that google/closure-compiler-js#79 is resolved, btw.

[1] https://github.com/google/closure-compiler-npm/blob/master/lib/node/closure-compiler-js.js#L52

@ChadKillingsworth
Copy link
Collaborator

Oh nice catch. I'll correct that.

@ChadKillingsworth
Copy link
Collaborator

Fixed by #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants