-
Notifications
You must be signed in to change notification settings - Fork 1.1k
/
TypeCheckNoTranspileTest.java
5249 lines (4843 loc) · 152 KB
/
TypeCheckNoTranspileTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
* Copyright 2017 The Closure Compiler Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.javascript.jscomp;
import static com.google.common.truth.Truth.assertThat;
import com.google.javascript.jscomp.CompilerOptions.LanguageMode;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Tests {@link TypeCheck} on non-transpiled code. */
@RunWith(JUnit4.class)
public final class TypeCheckNoTranspileTest extends TypeCheckTestCase {
@Override
protected CompilerOptions getDefaultOptions() {
CompilerOptions options = super.getDefaultOptions();
options.setLanguageIn(LanguageMode.ECMASCRIPT_NEXT);
options.setLanguageOut(LanguageMode.ECMASCRIPT_NEXT);
return options;
}
@Test
public void testArrowInferredReturn() {
// TODO(johnlenz): infer simple functions return results.
// Verify arrows have do not have an incorrect inferred return.
testTypes(
lines(
"let fn = () => {",
" return 1;",
"};",
"var /** null */ x = fn();"));
}
@Test
public void testArrowBlocklessInferredReturn() {
// TODO(johnlenz): infer simple functions return results.
// Verify arrows have do not have an incorrect inferred return.
testTypes(
lines(
"let fn = () => 1;",
"var /** null */ x = fn();"));
}
@Test
public void testArrowRightScopeForBody() {
testTypes(
lines(
"/** @type {string} */ let a = 's';",
"/** ",
" @param {number} a",
" @return {null}",
"*/",
"let fn = (a) => {",
" return a;",
"}"),
lines(
"inconsistent return type",
"found : number",
"required: null"));
}
@Test
public void testArrowRightBodyScopeForBlocklessBody() {
testTypes(
lines(
"/** @type {string} */ let a = 's';",
"/** ",
" @param {number} a",
" @return {null}",
"*/",
"let fn = (a) => a",
""),
lines(
"inconsistent return type",
"found : number",
"required: null"));
}
@Test
public void testArrowCorrectThis() {
testTypes(
lines(
"/** @this {String} */ function fn() {",
" /** ",
" @return {null}",
" */",
" let fn = () => {",
" return this;",
" }",
"}"),
lines(
"inconsistent return type",
"found : String",
"required: null"));
}
@Test
public void testArrowBlocklessCorrectThis() {
testTypes(
lines(
"/** @this {String} */ function fn() {",
" /** ",
" @return {null}",
" */",
" let fn = () => this;",
"}"),
lines(
"inconsistent return type",
"found : String",
"required: null"));
}
@Test
public void testArrowCorrectArguments() {
testTypes(
lines(
"/** @this {String} */ function fn() {",
" {",
" /** @type {number} */ let arguments = 1;",
" /** @return {null} */",
" let fn = () => {",
" return arguments;",
" }",
" }",
"}"),
lines(
"inconsistent return type",
"found : number",
"required: null"));
}
@Test
public void testArrowBlocklessCorrectArguments() {
testTypes(
lines(
"/** @this {String} */ function fn() {",
" {",
" /** @type {number} */ let arguments = 1;",
" /** @return {null} */",
" let fn = () => arguments;",
" }",
"}"),
lines(
"inconsistent return type",
"found : number",
"required: null"));
}
@Test
public void testArrowCorrectInheritsArguments() {
testTypesWithExtraExterns(
lines(
"/** @type {!Arguments} */ var arguments;"),
lines(
"/** @this {String} */ function fn() {",
" {",
" /** @return {null} */",
" let fn = () => {",
" return arguments;",
" }",
" }",
"}"),
lines(
"inconsistent return type",
"found : Arguments",
"required: null"));
}
@Test
public void testArrowBlocklessCorrectInheritsArguments() {
testTypesWithExtraExterns(
lines(
"/** @type {!Arguments} */ var arguments;"),
lines(
"/** @this {String} */ function fn() {",
" {",
" /** @return {null} */",
" let fn = () => arguments;",
" }",
"}"),
lines(
"inconsistent return type",
"found : Arguments",
"required: null"));
}
@Test
public void testAsyncArrowWithCorrectBlocklessReturn() {
testTypes(
lines(
"function takesPromiseProvider(/** function(): !Promise<number> */ getPromise) {}",
"takesPromiseProvider(async () => 1);"));
}
@Test
public void testAsyncArrowWithIncorrectBlocklessReturn() {
testTypes(
lines(
"function takesPromiseProvider(/** function(): !Promise<string> */ getPromise) {}",
"takesPromiseProvider(async () => 1);"),
lines(
"inconsistent return type", // preserve newline
"found : number",
"required: (IThenable<string>|string)"));
}
@Test
public void testTypedefOfPropertyInBlock() {
disableStrictMissingPropertyChecks();
testTypesWithExterns(
"/** @interface */ function Foo() {}",
lines(
"/** @constructor */",
"function Bar(/** !Foo */ foo) {",
" /** @type {!Foo} */",
" this.foo = foo;",
" {",
" /** @typedef {boolean} */",
" this.foo.bar;",
" (() => this.foo.bar)();",
" }",
"}"));
}
@Test
public void testTypedefOfPropertyInFunctionScope() {
disableStrictMissingPropertyChecks();
testTypesWithExterns(
"/** @interface */ function Foo() {}",
lines(
"/** @constructor */",
"function Bar(/** !Foo */ foo) {",
" /** @type {!Foo} */",
" this.foo = foo;",
" /** @typedef {boolean} */",
" this.foo.bar;",
" {",
" (() => this.foo.bar)();",
" }",
"}"));
}
@Test
public void testArrayLitSpread() {
// TODO(bradfordcsmith): check spread in array literal
// Note that there's not much point in doing such a check until we check array literal
// elements in general.
// See https://github.com/google/closure-compiler/issues/312
testTypesWithCommonExterns(
lines(
"/** @type {!Array<string>} */", // preserve newlines
"const strings = [];",
"/** @type {!Array<number>} */",
"const numbers = [...strings];", // This should generate an error
""));
}
@Test
public void testArrayLitSpreadNonIterable() {
testTypes(
lines(
"/** @type {!Array<number>} */", // preserve newlines
"const numbers = [...1];",
""),
lines(
"Spread operator only applies to Iterable types",
"found : number",
"required: Iterable"));
}
@Test
public void testTypecheckExpressionInArrayLitSpread() {
testTypesWithCommonExterns(
lines(
"/** @type {!Array<string>} */", // preserve newlines
"const strings = [];",
"/** @type {!Array<number>} */",
"let numbers = [];",
"const a = [...(numbers = strings)];",
""),
lines(
"assignment", // preserve newlines
"found : Array<string>",
"required: Array<number>"));
}
@Test
public void testInferTypesFromExpressionInArrayLitSpread() {
testTypesWithCommonExterns(
lines(
"/** @type {!Array<string>} */", // preserve newlines
"const strings = [];",
"let inferred = 1;",
"const a = [...(inferred = strings)];",
"/** @type {null} */",
"const n = inferred;",
""),
lines(
"initializing variable", // preserve newlines
"found : Array<string>",
"required: null"));
}
@Test
public void testSpreadAndFollowingParametersNotTypeChecked() {
testTypesWithExtraExterns(
lines(
"/**", // extra externs
" * @param {number} num",
" * @param {string} str",
" * @param {boolean} bool",
" */",
"function use(num, str, bool) {}",
""),
lines(
"/** @type {!Array<null>} */ const nulls = [];", // input lines
"use(1, ...nulls, null, null);"));
// TODO(bradfordcsmith): Should get an error since there's no way for `str` and `bool` params
// to get the right types here.
}
@Test
public void testSpreadArgumentTypeCheckedForVarArgs() {
testTypesWithExtraExterns(
lines(
"/**", // extra externs
" * @param {number} num",
" * @param {...string} var_args",
" */",
"function use(num, var_args) {}",
""),
lines(
"/** @type {!Array<null>} */ const nulls = [];", // input lines
"use(1, ...nulls);"));
// TODO(bradfordcsmith): Should get an error since `nulls` doesn't contain strings.
}
@Test
public void testSpreadArgumentBackInference() {
testTypesWithExtraExterns(
lines(
"/**", // extra externs
" * @param {number} num",
" * @param {...{prop: number}} var_args",
" */",
"function use(num, var_args) {}",
""),
lines(
"use(1, ...[{}]);"));
// TODO(bradfordcsmith): Should generate error indicating inferred type of `[{}]`
// as `{Iterable<{prop: (number|undefined)}>}
}
@Test
public void testTooManyNonSpreadParameters() {
testTypesWithExtraExterns(
lines(
"/**", // extra externs
" * @param {number} num",
" * @param {string} str",
" * @param {boolean} bool",
" */",
"function use(num, str, bool) {}",
""),
lines(
"/** @type {!Array<*>} */ const unusables = [];", // input lines
"use(1, 'hi', ...unusables, null, null);"), // more than 3 non-spread parameters
"Function use: called with at least 4 argument(s)."
+ " Function requires at least 3 argument(s) and no more than 3 argument(s).");
}
@Test
public void testArgumentSpreadDoesNotBlockTypeCheckOfInitialParameters() {
testTypesWithExtraExterns(
lines(
"/**", // extra externs
" * @param {number} num",
" * @param {string} str",
" * @param {boolean} bool",
" */",
"function use(num, str, bool) {}",
""),
"use('should be number', ...[]);",
lines(
"actual parameter 1 of use does not match formal parameter",
"found : string",
"required: number"));
}
@Test
public void testArgumentSpreadNonIterable() {
testTypesWithExtraExterns(
"function use(x) {}",
"use(...1);",
lines(
"Spread operator only applies to Iterable types",
"found : number",
"required: Iterable"));
}
@Test
public void testTypecheckExpressionInArgumentSpread() {
testTypesWithExtraExterns(
"function use(x) {}",
lines(
"/** @type {!Array<string>} */", // preserve newlines
"const strings = [];",
"/** @type {!Array<number>} */",
"let numbers = [];",
"use(...(numbers = strings));",
""),
lines(
"assignment", // preserve newlines
"found : Array<string>",
"required: Array<number>"));
}
@Test
public void testInferTypesFromExpressionInArgumentSpread() {
testTypesWithExtraExterns(
"function use(x) {}",
lines(
"/** @type {!Array<string>} */", // preserve newlines
"const strings = [];",
"let inferred = 1;",
"use(...(inferred = strings));",
"/** @type {null} */",
"const n = inferred;",
""),
lines(
"initializing variable", // preserve newlines
"found : Array<string>",
"required: null"));
}
@Test
public void testOnlyRestParameterWithoutJSDocCalledWithNoArgs() {
testTypes(
lines(
"", // input lines
"function use(...numbers) {}",
"use();", // no args provided in call - should be OK
""));
}
@Test
public void testBadRestJSDoc() {
// TODO(lharker): this should warn that the "number" should be "...number".
// Currently we issue this warning in Es6RewriteRestAndSpread.
testTypes(
"/** @param {number} numbers */ function f(...numbers) { var /** null */ n = numbers; }",
lines(
"initializing variable", //
"found : Array<number>",
"required: null"));
}
@Test
public void testOnlyRestParameterWithoutJSDocCalledWithArgs() {
testTypes(
lines(
"", // input lines
"function use(...numbers) {}",
"use(1, 'hi', {});",
""));
}
@Test
public void testOnlyRestParameterWithJSDocCalledWithNoArgs() {
testTypes(
lines(
"/**", // input lines
" * @param {...number} numbers",
" */",
"function use(...numbers) {}",
"use();", // no args provided in call - should be OK
""));
}
@Test
public void testOnlyRestParameterWithJSDocCalledWithGoodArgs() {
testTypes(
lines(
"/**", // input lines
" * @param {...number} numbers",
" */",
"function use(...numbers) {}",
"use(1, 2, 3);",
""));
}
@Test
public void testOnlyRestParameterWithJSDocCalledWithBadArg() {
testTypes(
lines(
"/**", // input lines
" * @param {...number} numbers",
" */",
"function use(...numbers) {}",
"use(1, 'hi', 3);",
""),
lines(
"actual parameter 2 of use does not match formal parameter",
"found : string",
"required: number"));
}
@Test
public void testNormalAndRestParameterWithJSDocCalledWithOneArg() {
testTypes(
lines(
"/**", // input lines
" * @param {string} str",
" * @param {...number} numbers",
" */",
"function use(str, ...numbers) {}",
"use('hi');", // no rest args provided in call - should be OK
""));
}
@Test
public void testNormalAndRestParameterWithJSDocCalledWithGoodArgs() {
testTypes(
lines(
"/**", // input lines
" * @param {string} str",
" * @param {...number} numbers",
" */",
"function use(str, ...numbers) {}",
"use('hi', 2, 3);",
""));
}
@Test
public void testOnlyRestParameterWithJSDocCalledWithBadNormalArg() {
testTypes(
lines(
"/**", // input lines
" * @param {string} str",
" * @param {...number} numbers",
" */",
"function use(str, ...numbers) {}",
"use(1, 2, 3);",
""),
lines(
"actual parameter 1 of use does not match formal parameter",
"found : number",
"required: string"
));
}
@Test
public void testOnlyRestParameterWithJSDocCalledWithBadRestArg() {
testTypes(
lines(
"/**", // input lines
" * @param {string} str",
" * @param {...number} numbers",
" */",
"function use(str, ...numbers) {}",
"use('hi', 'there', 3);",
""),
lines(
"actual parameter 2 of use does not match formal parameter",
"found : string",
"required: number"));
}
@Test
public void testRestParameterInCallbackIsInferred() {
testTypes(
lines(
"/** @param {function(...number)} callback */",
"function f(callback) {}",
"",
"f((...strings) => {",
" const /** null */ n = strings;", // verify that this causes a type mismatch
"});"),
lines(
"initializing variable", //
"found : Array<number>",
"required: null"));
}
@Test
public void testExponent1() {
testTypes(
lines(
"function fn(someUnknown) {",
" var x = someUnknown ** 2;", // infer the result
" var /** null */ y = x;",
"}"),
lines(
"initializing variable",
"found : number",
"required: null"));
}
@Test
public void testExponent2() {
testTypes(
lines(
"function fn(someUnknown) {",
" var x = someUnknown;",
" x **= 2;", // infer the result
" var /** null */ y = x;",
"}"),
lines(
"initializing variable",
"found : number",
"required: null"));
}
@Test
public void testExponent3() {
testTypes(
lines(
"function fn(someUnknown) {",
" var y = true ** 3;",
"}"),
lines(
"left operand",
"found : boolean",
"required: number"));
}
@Test
public void testExponent4() {
testTypes(
lines(
"function fn(someUnknown) {",
" var y = 1; y **= true;",
"}"),
lines(
"right operand",
"found : boolean",
"required: number"));
}
@Test
public void testDuplicateCatchVarName() {
// Make sure that catch variables with the same name are considered to be distinct variables
// rather than causing a redeclaration error.
testTypes(
lines(
"try { throw 1; } catch (/** @type {number} */ err) {}",
"try { throw 'error'; } catch (/** @type {string} */ err) {}",
""));
}
@Test
public void testTypedefFieldInLoopLocal() {
testTypesWithCommonExterns(
lines(
"/** @typedef {{num: number, maybeNum: ?number}} */",
"let XType;",
"",
"/** @param {!Array<!XType>} xlist */",
"function f(xlist) {",
" for (let i = 0; i < xlist.length; i++) {",
" /** @type {!XType} */",
" const x = xlist[i];",
" if (x.maybeNum === null) {",
" continue;",
" }",
" x.num = x.maybeNum;",
" }",
"}",
""));
}
@Test
public void testTypedefFieldInLoopGlobal() {
testTypesWithCommonExterns(
lines(
"/** @typedef {{num: number, maybeNum: ?number}} */",
"let XType;",
"",
"/** @type {!Array<!XType>} */",
"const xlist = [{maybeNum: null, num: 0}, {maybeNum: 1, num: 1}];",
"",
"for (let i = 0; i < xlist.length; i++) {",
" /** @type {!XType} */",
" const x = xlist[i];",
" if (x.maybeNum === null) {",
" continue;",
" }",
// TODO(b/78364240): Compiler should realize that x.maybeNum must be a number here
" x.num = x.maybeNum;",
"}",
""),
lines(
"assignment to property num of x", // preserve newlines
"found : (null|number)",
"required: number"));
}
@Test
public void testTypedefAlias() {
// Ensure that the type of a variable representing a typedef is "undefined"
testTypes(
lines(
"/** @typedef {number} */", // preserve newlines
"var MyNumber;",
"var ns = {};",
"ns.MyNumber = MyNumber;",
"/** @type {string} */ (ns.MyNumber);",
""),
lines(
"invalid cast - must be a subtype or supertype", // preserve newlines
"from: undefined",
"to : string"));
}
@Test
public void testGetTypedPercent() {
// Make sure names declared with `const` and `let` are counted correctly for typed percentage.
// This was created my a modifying a copy of TypeCheckTest.testGetTypedPercent1()
String js =
lines(
"const id = function(x) { return x; }",
"let id2 = function(x) { return id(x); }");
assertThat(getTypedPercent(js)).isWithin(0.1).of(50.0);
}
@Test
public void testBlockScopedVarInLoop1() {
disableStrictMissingPropertyChecks();
testTypesWithCommonExterns(
lines(
"/** @constructor */ function Node() {};",
"function g(/** Node */ n){",
" n.foo = {bar: 3};",
"}",
"function f(/** !Array<!Node> */ arr){",
" for (var i = 0; i < arr.length; i++) {",
" const tile = arr[i];",
" const bar = tile.foo.bar;",
// this assignment shouldn't cause 'tile.foo' to be inferred as undefined above.
" tile.foo = undefined",
" }",
"}"));
}
@Test
public void testBlockScopedVarInLoop2() {
testTypes(
lines(
"while (true) {",
" let num;",
" let /** undefined */ y = num;",
// null assignment shouldn't make us think num could be null on the previous line.
" num = null;",
"}"));
}
@Test
public void testBlockScopedVarInLoop3() {
// Tests that the qualified name alias.num is reset between loop iterations
testTypes(
lines(
"function takesNumber(/** number */ n) {}",
"",
"function f(/** {num: ?number} */ obj) {",
" for (const _ in {}) {",
" const alias = obj;",
" if (alias.num === null) {",
" continue;",
" }",
" takesNumber(alias.num);",
" }",
"}"));
}
@Test
public void testGlobalEnumWithLet() {
testTypes(
lines(
"/** @enum */", // type defaults to {number}
"let E = {A: 1, B: 2};",
"",
"/**",
" * @param {E} x",
" * @return {number}",
" */",
"function f(x) {return x}"));
}
@Test
public void testGlobalEnumWithConst() {
testTypes(
lines(
"/** @enum */", // type defaults to {number}
"const E = {A: 1, B: 2};",
"",
"/**",
" * @param {E} x",
" * @return {number}",
" */",
"function f(x) {return x}"));
}
@Test
public void testLocalEnumWithLet() {
// TODO(bradfordcsmith): Local enum types should be non-nullable just like the global ones.
testTypes(
lines(
"{",
" /** @enum */", // type defaults to {number}
" let E = {A: 1, B: 2};",
"",
" /**",
" * @param {E} x",
" * @return {number}",
" */",
" function f(x) {return x}",
"}"),
lines(
"inconsistent return type",
"found : (E<number>|null)",
"required: number"));
}
@Test
public void testLocalEnumWithConst() {
// TODO(bradfordcsmith): Local enum types should be non-nullable just like the global ones.
testTypes(
lines(
"{",
" /** @enum */", // type defaults to {number}
" const E = {A: 1, B: 2};",
"",
" /**",
" * @param {E} x",
" * @return {number}",
" */",
" function f(x) {return x}",
"}"),
lines(
"inconsistent return type",
"found : (E<number>|null)",
"required: number"));
}
@Test
public void testGlobalTypedefWithLet() {
testTypes(
lines(
"/** @typedef {number} */",
"let Bar;",
"/** @param {Bar} x */",
"function f(x) {}",
"f('3');",
""),
lines(
"actual parameter 1 of f does not match formal parameter",
"found : string",
"required: number"));
}
@Test
public void testLocalTypedefWithLet() {
testTypes(
lines(
"{",
" /** @typedef {number} */",
" let Bar;",
" /** @param {Bar} x */",
" function f(x) {}",
" f('3');",
"}",
""),
lines(
"actual parameter 1 of f does not match formal parameter",
"found : string",
"required: number"));
}
@Test
public void testConstWrongType() {
testTypes(
"/** @type {number} */ const x = 'hi';",
lines(
"initializing variable", // preserve newlines
"found : string",
"required: number"));
}
@Test
public void testLetWrongType() {
testTypes(
"/** @type {number} */ let x = 'hi';",
lines(
"initializing variable", // preserve newlines
"found : string",
"required: number"));
}
@Test
public void testLetInitializedToUndefined1() {
testTypes(
"let foo; let /** number */ bar = foo;",
lines(
"initializing variable", // preserve newline
"found : undefined",
"required: number"));
}
@Test
public void testLetInitializedToUndefined2() {
// Use the declared type of foo instead of inferring it to be undefined.
testTypes("let /** number */ foo; let /** number */ bar = foo;");
}
@Test
public void testLetInitializedToUndefined3() {
// TODO(sdh): this should warn because foo is potentially undefined when getFoo() is called.
// See comment in TypeInference#updateScopeForTypeChange
testTypes(
lines(
"let foo;",
"/** @return {number} */",
"function getFoo() {",
" return foo;",
"}",
"function setFoo(/** number */ num) {",
" foo = num;",
"}"));
}
@Test
public void testForOf1() {
testTypes("/** @type {!Iterable} */ var it; for (var elem of it) {}");
}
@Test
public void testForOf2() {
testTypes(
lines(
"function takesString(/** string */ s) {}",
"/** @type {!Iterable<string>} */ var it;",
"for (var elem of it) { takesString(elem); }"));
}
@Test
public void testForOf3() {
testTypes(
lines(
"function takesString(/** string */ s) {}",
"/** @type {!Iterable<number>} */ var it;",
"for (var elem of it) { takesString(elem); }"),
lines(
"actual parameter 1 of takesString does not match formal parameter",
"found : number",
"required: string"));
}
@Test
public void testForOf4() {
testTypes("/** @type {!Iterable} */ var it; var obj = {}; for (obj.elem of it) {}");
}
@Test
public void testForOf5() {
// We infer the type of a qualified name in a for-of loop initializer
testTypes(
lines(
"function takesString(/** string */ s) {}",
"",
"function f(/** !Iterable<number> */ it) {",
" var obj = {};",
" for (obj.elem of it) {",
" takesString(obj.elem);",
" }",
"}"),
lines(
"actual parameter 1 of takesString does not match formal parameter",
"found : number",
"required: string"));
}
@Test
public void testForOf_wrongLoopVarType1() {