Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External references renamed if the externs definition is a typedef #157

Open
blickly opened this issue Apr 29, 2014 · 4 comments
Open

External references renamed if the externs definition is a typedef #157

blickly opened this issue Apr 29, 2014 · 4 comments

Comments

@blickly
Copy link
Contributor

blickly commented Apr 29, 2014

This issue was imported from Closure Compiler's previous home at http://closure-compiler.googlecode.com

The link to the original issue is:
https://code.google.com/p/closure-compiler/issues/detail?id=1165

@laszlojakab
Copy link

Will the mentioned fix be turned on by default in the near future?

@MatrixFrog
Copy link
Contributor

I hope we can get to this in the next few weeks, yes. I think it will help a lot of people. In the meantime, @concavelenz, is there a flag so that users can turn it on for their projects?

@concavelenz
Copy link
Contributor

It looks like we currently only allow it to be set internally (gather_externs_from_types) as this was intended to be a temporary option. I wouldn't object to a patch to add accessors for CompilerOptions#gatherExternsFromTypes so that it can be set externally.

@erikonad
Copy link

What does being set internally mean? Where is the line to modify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants