Overriding implicit visibility

[teppeis]

In Closure, a child class cannot override visibility of a property with different visibility.
But if the parent visibility is not declared in the jsdoc explicitly (that is treated as @public implicitly if no @fileoverview), the child can change the visibility now.

Is this intentional or bug?

For example:

/**
 * @constructor
 */
app.Foo = function() {};

/**
 * @return {string}
 * @public
 */
app.Foo.prototype.explicitPublic = function() {
  return 'explicitPublic!';
};

/**
 * @return {string}
 */
app.Foo.prototype.implicitPublic = function() {
  return 'implicitPublic!';
};

/**
 * @constructor
 * @extends {app.Foo}
 */
app.Bar = function() {};

/**
 * Correct: `WARNING - Overriding PUBLIC property of app.Foo.prototype with PRIVATE property.`
 *
 * @override
 * @private
 */
app.Bar.prototype.explicitPublic = function() {
  return 'explicitPublic!';
};

/**
 * No warnings! Intentional?
 *
 * @override
 * @private
 */
app.Bar.prototype.implicitPublic = function() {
  return 'implicitPublic!';
};

Repro:

• playground
• https://github.com/teppeis-sandbox/closure-compiler-sandbox/tree/override-visibility

Also I found such cases in Closure Library, but it does not appear to be intentional.

[brad4d]

Created internal Google issue b/121377215

[brad4d]

Thanks for pointing this out @teppeis

[teppeis]

@Brad4 The following should be fixed at the same time.

• goog.ui.BidiInput.prototype.createDom
• goog.ui.MenuButton.prototype.handleBlur
• goog.ui.Palette.prototype.setContentInternal