Renaming can rename to a class already used

[iflan]

Originally reported on Google Code with ID 27

What steps will reproduce the problem?
1. pick a stylesheet
2. somewhere in that stylesheet put a class called 'a'
3. put a in --exluded-classes-from-renaming

What is the expected output? What do you see instead?

it is expected that no class will be renamed to 'a' as it is already in use

What version of the product are you using? On what operating system?

the latest

Please provide any additional information below.

came across this when adblock was hiding our site because 'body' was being renamed
to 'Ad' which was in the filters. Tried creating a class called 'Ad' but that was being
renamed and body was still 'Ad' so added it to the exclude renaming but would be worse
as 'body' was still 'Ad' and now we have two class definitions for 'Ad'

Reported by rhysbrettbowen on 2012-08-31 21:02:46

[iflan]

@rhysbrettbowen, sorry it has taken so long, but I will investigate. I was sure this was working with the --excluded_classes_from_renaming flag.

[iflan]

I think this is a documentation bug. You need to put the class that you want to rename in the --excluded-classes-from-renaming.

For example:

.oooo {
  background: blue;
}

.qqqqqqqq {
  color: pink;
}

run as:

$ java -jar ../closure-stylesheets/build/closure-stylesheets.jar --rename CLOSURE test-bug-46.gss 

produces:

.a{background:blue}.b{color:pink}

while:

$ java -jar ../closure-stylesheets/build/closure-stylesheets.jar --excluded-classes-from-renaming qqqqqqqq --rename CLOSURE test-bug-46.gss

produces:

.a{background:blue}.qqqqqqqq{color:pink}