Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoyTofu deprecation notice refers to non-public migration guide #177

Closed
dpursehouse opened this issue May 15, 2019 · 4 comments
Closed

SoyTofu deprecation notice refers to non-public migration guide #177

dpursehouse opened this issue May 15, 2019 · 4 comments

Comments

@dpursehouse
Copy link

The SoyTofu class is deprecated and the @deprecated tag in its javadoc says:

/**
 * @deprecated Use SoySauce instead. Apps/framework users should follow this migration guide
 *     go/af-soy-migration.
 */

go/af-soy-migration is an internal Google link and is not visible publicly.

Please replace this with a public link, or include the migration guide in this git repository.

@iteriani
Copy link
Contributor

It is included in the migration guide. See g3doc -> dev -> soysauce_migration.

@dpursehouse
Copy link
Author

See g3doc -> dev -> soysauce_migration

Please provide a link. As far as I can see there is only a "todo.md" under the g3doc path: https://github.com/google/closure-templates/blob/master/g3doc/todo.md

There is a http://doc/... link in there, but it also seems to be a Google internal link.

@emspishak
Copy link
Contributor

@dpursehouse
Copy link
Author

Thanks @emspishak

Would it be possible to replace the go/af-soy-migration in the source code with that link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants