Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

[unlikely to implement] Serialization helper #8

Open
nottombrown opened this issue Aug 23, 2018 · 0 comments
Open

[unlikely to implement] Serialization helper #8

nottombrown opened this issue Aug 23, 2018 · 0 comments
Labels
wontfix This will not be worked on

Comments

@nottombrown
Copy link
Contributor

Follow up to #4

If serialization of the args becomes annoying (for example, if researchers frequently try to serialize strings have characters that bash mis-interprets), we could let the user set flags within their executable function also. I think that we likely don't need to do this though.

# train.py
def main():
  ...

if __name__ == '__main__':
  FLAGS = argparser.parse()
  berg.setup_flags(FLAGS)
  main()

My current thinking is that this is more trouble than it is worth, and that serializing through CLI flags yields code that is easier to understand and more portable than this proposal.

@nottombrown nottombrown added help wanted Extra attention is needed wontfix This will not be worked on and removed help wanted Extra attention is needed labels Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant