Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

[feature] Prepend a prefix to all metrics #195

Closed
artherd42 opened this issue Jan 23, 2019 · 4 comments
Closed

[feature] Prepend a prefix to all metrics #195

artherd42 opened this issue Jan 23, 2019 · 4 comments
Assignees
Milestone

Comments

@artherd42
Copy link

A meaningful prefix, e.g. cloudprober_, would help to distinguish the cloudprober metrics from other metrics. It should be prepended to all stats, automatically.

@manugarg
Copy link
Contributor

Is this request specifically for prometheus surfacer? To avoid breaking existing deployments, we can actually make it an option, rather than doing it automatically.

@tklovett
Copy link

tklovett commented May 30, 2019

👍 for this request – finding and understanding a metric called total or success in Prometheus's auto-completion is challenging. This is especially true for new team members who were not involved in getting Cloudprober set up initially.

@manugarg manugarg self-assigned this May 30, 2019
manugarg added a commit that referenced this issue May 31, 2019
This has been a much asked feature:
#195

PiperOrigin-RevId: 250729862
manugarg added a commit that referenced this issue May 31, 2019
This has been a much asked feature:
#195

PiperOrigin-RevId: 250729862
@manugarg
Copy link
Contributor

manugarg commented May 31, 2019

Feature has been added to the HEAD now. Metrics prefix can be changed by having the following in cloudprober config:

surfacer {
  type: PROMETHEUS

  prometheus_surfacer {
    metrics_prefix: "cloudprober_"
  }
}

@manugarg manugarg added this to the v0.10.3 milestone Jun 10, 2019
@manugarg
Copy link
Contributor

Released in v0.10.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants