Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Enhance ping probe testing #227

Closed
manugarg opened this issue Mar 20, 2019 · 2 comments
Closed

Enhance ping probe testing #227

manugarg opened this issue Mar 20, 2019 · 2 comments

Comments

@manugarg
Copy link
Contributor

Improve ping probe tests to cover cases like the one reported in: #225.

@manugarg
Copy link
Contributor Author

Just want to add that detecting #225 through unit tests was really hard because that bug is triggered only if we receive packets smaller than the configured packet size (payload size + icmp header size). This happens with raw sockets in the wild because kernel delivers all kind of ICMP packets to us and those packets may be smaller than what cloudprober would send.

Given this specific nature of #225, I'd consider this bug to be lower priority.

@manugarg
Copy link
Contributor Author

manugarg commented Nov 2, 2021

Closing this now, as noted earlier this may not be worth fixing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant