Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint check in CI #127

Closed
oliverchang opened this issue Feb 7, 2019 · 2 comments
Closed

Add lint check in CI #127

oliverchang opened this issue Feb 7, 2019 · 2 comments

Comments

@oliverchang
Copy link
Collaborator

No description provided.

@oliverchang oliverchang mentioned this issue Feb 7, 2019
Closed
@cclauss
Copy link
Contributor

cclauss commented Feb 8, 2019 •
edited

Also note that linters like flake8 and pylint will raise different errors on Python 2 and Python 3 (because their Abstract Syntax Trees are different) so it would be good it the CI could do parallel lint runs on both Python 2.7 and 3.7.

@inferno-chromium
Copy link
Collaborator

@cclauss - right now, we only support 2.7. But Python 3 support should be coming this year.
Linting can be run right now, with python butler.py lint.

oliverchang added a commit that referenced this issue Feb 11, 2019
@oliverchang
Move pylint requirement to CI (#127).
f28edc7
oliverchang added a commit that referenced this issue Feb 11, 2019
@oliverchang
Move pylint and yapf requirements to CI (#127) (#160)
1d52e75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliverchang @cclauss @inferno-chromium