Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFlite artifacts are called "cifuzz-****" #77

Closed
evverx opened this issue Jan 21, 2022 · 5 comments
Closed

CFlite artifacts are called "cifuzz-****" #77

evverx opened this issue Jan 21, 2022 · 5 comments

Comments

@evverx
Copy link
Contributor

evverx commented Jan 21, 2022

I'm not sure how important this is but looking at https://github.com/evverx/libbpf/actions/runs/1728607427 it seems the artifacts should be called "cflite-***" instead. The only scenario I can imagine where it could break something is when both CFLite and CIFuzz are enabled at the same time though.

@oliverchang
Copy link
Collaborator

@jonathanmetzman thoughts? It doesn't seem too important to me, and enabling both at the same time doesn't make much sense AFAICT.

@evverx
Copy link
Contributor Author

evverx commented Jan 24, 2022

I think as long as CIFuzz is incompatible with forks due to google/oss-fuzz#3731 it kind of makes sense to use both CIFuzz and CFLite. I don't think anyone does this in practice though.

@jonathanmetzman
Copy link
Collaborator

I think ideally we should use "clusterfuzzlite" rather than CIFuzz which isn't really the "brand" we are going to use moving forward.
I can change the name but it will break existing users. Better to do this sooner rather than later but I'm leaning towards not changing it.

@evverx
Copy link
Contributor Author

evverx commented Jan 26, 2022

There is another place where CFLite doesn't pop up even though I think it should. As far as I can tell there is no alternative to the CIFUZZ environment variable on CFLite.

@evverx
Copy link
Contributor Author

evverx commented May 7, 2023

I think there is exactly one project where both CIFuzz and CFLite are used and I'm pretty sure it can live with artifacts named like this :-) Closing.

@evverx evverx closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants