Skip to content
This repository has been archived by the owner on Apr 22, 2020. It is now read-only.

Add Chapel to the list of supported language #518

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

victor-ludorum
Copy link

@bradcray Sir, I have made pull request kindly review it

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@victor-ludorum
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!


[
[PR['PR_KEYWORD'],
/^(?:align|as|atomic|begin|break|by|catch|class|cobegin|coforall|continue|delete|dmapped|do|else|enum|except|export|extern|for|forall|if|index|inline|in|iter|label|lambda|let|local|module|new|noinit|on|only|otherwise|pragma|private|proc|prototype|public|record|reduce|require|return|scan|select|serial|then|throw|throws|try|union|use|var|when|where|while|with|yield|zip|bool|real|int|uint|imag|complex|dmap|domain|string|range|tuple|config|const|param|private|public|sparse|single|type|enum)\b/, null],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've missed keyword 'sync' here.

@victor-ludorum
Copy link
Author

victor-ludorum commented Jan 20, 2018

Thanks @aditmehta9 I have added it . Please suggest if any other improvement is necessary

@AliabbasMerchant
Copy link

Guys,
What is the current status of this PR??
Is it okay to be merged??
Or is there a need to make changes?

@bradcray
Copy link

bradcray commented Mar 6, 2019

@AliabbasMerchant, @victor-ludorum: I opened issue #587 in hopes of determining what needs to happen next to move your PR forward.

(@AliabbasMerchant, I assume your question is directed toward the code-prettify core developers and not at Victor or myself?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants