Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to detect encoding from input streams #7

Open
ghost opened this issue Sep 18, 2017 · 1 comment
Open

Add possibility to detect encoding from input streams #7

ghost opened this issue Sep 18, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 18, 2017

Right now it seems the detector is only able to work with input arrays, it would be very useful to allow input streams as well. This makes sense when the input files are very large and it's not memory efficient to load them entirely into memory.

@google google deleted a comment from penvanpen Jun 7, 2018
@JinsukKim
Copy link
Collaborator

Thanks for the input and sorry for belated response. Would appreciate your contribution to make it better. The way the detector works however doesn't require too much memory. It was mainly designed with web documents in mind, and first few KB will suffice to make a probabilistic decision. It also returns the # of bytes it consumed to do that. It rarely goes over 3~4 KB. The rest of the input is ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@JinsukKim and others