Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run clippy on code examples #508

Open
qwandor opened this issue Mar 15, 2023 · 1 comment
Open

Run clippy on code examples #508

qwandor opened this issue Mar 15, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@qwandor
Copy link
Collaborator

qwandor commented Mar 15, 2023

Running it on the code in Cargo workspaces should be straightforward. It is unclear how to do so on inline code samples.
@mgeisler
Copy link
Collaborator

It is unclear how to do so on inline code samples.

Yeah, for that we would need to extend mdbook test — or perhaps this could be something we could extend mdbook-keeper (see #175) to do? I've talked with the mdbook authors before about extending and improving mdbook test, and I get the impression that they would prefer to offload the testing functionality.

@mgeisler mgeisler added the good first issue Good for newcomers label Mar 19, 2023
@mgeisler mgeisler added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgeisler @qwandor