-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support call external commands as transformation #98
Comments
Hi Shuai, The general approach that we've been following is to implement specific transformations (that can delegate on another tool/sub-process) instead of a general "black-box" transform where you can run any command. There are several reasons for this, for example it provides a much better API in terms of the configuration. If you see a transform like (just making this up):
it's much clear and scoped than something like:
and there's also the problem of, how do you specify the binary, how it's resolved, etc. But the main issue is reversibility. Having a blind transform that runs some command does not offer any control on that, unless you make this transform explicitly non-reversible, or you have a reverse field. We do have some format transformations internally, and they are implemented in this way:
where the MyFormatToolOptions resolves the binary to a default location (for example Note that in this case we set explicitly that the format transformation reverse is noop. Could you say more about the format tool that you want to run? Is it open source? Also, are happy to accept contributions :) |
I want support for:
Would you like to give more details about |
I'd like to run code formatting in a copybara workflow, which needs to call external commands as transformation.
The text was updated successfully, but these errors were encountered: