Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Server::start(host, port, callback, OnError) #79

Closed
softwareCobbler opened this issue Feb 27, 2022 · 0 comments
Closed

Support for Server::start(host, port, callback, OnError) #79

softwareCobbler opened this issue Feb 27, 2022 · 0 comments

Comments

@softwareCobbler
Copy link

dap::net::Server::start right now always binds to "localhost", which is a fine default; but I ran into trying to build this into a javaagent, to be used on a JVM inside a docker container (so debug client is running on host, cppdap is in a container). Apparently, docker container's port forwarding from host<->container requires the applications inside the container to be listening to 0.0.0.0.

Easy fix on the surface -- add an overload that accepts const char* host -- curious if this has drawbacks I don't see, or there is already a built-in solution I am overlooking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant