Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gradle's upcoming incremental annotation processing feature #959

Closed
ZakTaccardi opened this issue Nov 20, 2017 · 7 comments
Closed

Comments

@ZakTaccardi
Copy link

https://github.com/gradle/incap

Similar to #298

@ronshapiro
Copy link

I don't see any docs for this, nor any timeline for when/if this is actually happening. Do you have any context on this?

@gabrielittner
Copy link

gabrielittner commented Nov 20, 2017

we do not support APs that have a many-to-1 or many-to-many annotation:genfile relationship

https://github.com/gradle/incap/issues/100

That sounds like a limitation that Dagger falls under.

@ZakTaccardi
Copy link
Author

I don't see any docs for this, nor any timeline for when/if this is actually happening. Do you have any context on this?

Unfortunately, not really. This is the biggest issue that blocks me from using Dagger. Unfortunately now annotation processing + gradle == no incremental builds which is a huge pain point in the android development experience.

I was hoping somehow the dagger2/gradle team on this could work together to make this happen.

@ronshapiro
Copy link

Thanks @gabrielittner. In that case, I think it makes sense to close this...

@JakeWharton
Copy link

The gains to be had from modularization which provides parallelism and compilation avoidance likely will dwarf anything incremental annotation processing could achieve.

@ZakTaccardi
Copy link
Author

The gains to be had from modularization which provides parallelism and compilation avoidance likely will dwarf anything incremental annotation processing could achieve.

We should definitely modularize. But it would be nice to have both

@LuigiPapino
Copy link

I actually got a 50% cut on my clean build time, modularizing the app.
But the process to adapt the dagger components required some effort. Didn't find a way to use properly AndroidInjectors and @Contribute within a feature module.

But definitely worth it for the build speed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants