Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PortabilityJob.to/fromMap in favor of JSON serialization #191

Open
rtannenbaum opened this issue Mar 8, 2018 · 2 comments
Open

Remove PortabilityJob.to/fromMap in favor of JSON serialization #191

rtannenbaum opened this issue Mar 8, 2018 · 2 comments
Labels
backlog

Comments

@rtannenbaum
Copy link
Contributor

cc @jimmarino as discussed on Slack and @holachuy for the discussion on #187
@rtannenbaum rtannenbaum mentioned this issue Mar 8, 2018
Merged
@rtannenbaum rtannenbaum mentioned this issue Apr 2, 2018
Merged
@rtannenbaum
Copy link
Contributor Author

This came up in #308, it should probably be up to the JobStore implementation how it wants to de/serialize PortabilityJob. See the Azure store for an example. We should tweak the Google & local impls to do the same and then remove the map methods.

@rtannenbaum rtannenbaum mentioned this issue Mar 7, 2019
Closed
@seehamrun
Copy link
Member

Came up again in #670 we should really fix this and switch to JSON :)

@seehamrun seehamrun mentioned this issue May 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seehamrun @rtannenbaum @holachuy