Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Gmail Importer tests #363

Open
seehamrun opened this issue Apr 16, 2018 · 26 comments
Open

Google Gmail Importer tests #363

seehamrun opened this issue Apr 16, 2018 · 26 comments
Labels
good first issue Good for newcomers

Comments

@seehamrun
Copy link
Collaborator

No description provided.

@chamorajg
Copy link

i would like to contribute for this project. Can you guys help me out on how to start and proceed with this issue ?

@chamorajg
Copy link

Can someone help me out ???

@seehamrun
Copy link
Collaborator Author

Hi! Thanks for helping out!

The Gmail importer and exporter live under extensions/data-transfer/portability-data-transfer-google/src/main/java/org/datatransferproject/datatransfer/google/mail

We have some minimal tests under extensions/data-transfer/portability-data-transfer-google/src/test/java/org/datatransferproject/datatransfer/google/mail

A good place to start is reading through the makeup of our adapter plug in model to understand how these pieces fit together. Feel free to add onto the test from there (looks like there are a couple of TODOs left in the code).

@holachuy
Copy link
Collaborator

holachuy commented Aug 3, 2018

In addition to that, I would add:

As far as an existing example for an importer test, please see:
https://github.com/google/data-transfer-project/blob/master/extensions/data-transfer/portability-data-transfer-google/src/test/java/org/datatransferproject/datatransfer/google/contacts/GoogleContactsImporterTest.java

We don't have a general test guidelines doc yet and would welcome any contribution you would like to make towards documentation if you are so inclined.

Here is a general guideline from the Google Testing Blog that may be helpful
https://testing.googleblog.com/2008/08/by-miko-hevery-so-you-decided-to.html

@chamorajg
Copy link

Thank you guys for your response.
I am going through the codebase now. It might take time to start but definitely do it.
Once again thank you guys.

@chamorajg
Copy link

I have installed the docker images for running locally. How to get the API keys

@holachuy
Copy link
Collaborator

We have some general documentation here about API keys. Let us know if there is anything that is unclear https://github.com/google/data-transfer-project/blob/master/Documentation/Keys.md

@chamorajg
Copy link

I tried running the dtp using docker-image when I use the localhost link I am not able to authenticate using API keys it says
401. That’s an error.
Error: invalid_client
The OAuth client was not found.
I get this when I try to run it locally.

@seehamrun
Copy link
Collaborator Author

Hi, this happens if the API key/secret are misconfigured. Which service are you getting the error for? Please double check that the client ID and secret that are configured on the service, match what you are passing in the secrets file.

@chamorajg
Copy link

Google API keys. I get the key id but how to get the secret key. I am confused on how to choose the required API for the concerned application. Can you just help me out.

@seehamrun
Copy link
Collaborator Author

You find some details on the flow of creating an oauth client for Google here: https://developers.google.com/identity/protocols/OAuth2WebServer#creatingcred

If you already created the oauth client, you can view the ID and secret by going to the cloud console credentials page: https://console.developers.google.com/apis/credentials and selecting the oauth client you are trying to access.

Let me know if that makes sense, and please point out places where our documentation is lacking. Thanks!

@chamorajg
Copy link

Yes now it all works. I guess documentation lacks few information about OAuth registration.

@cedricvanrompay
Copy link

When creating an OAuth client, what do you put for "authorized domain" if your DTP instance runs on your laptop's localhost?

@cedricvanrompay
Copy link

Ok, well turns out you can put whatever domain you want and you still get OAuth credentials.

Also, I don't know why it's written “cedricvanrompay unassigned olsona 4 hours ago”.
Really bad bug from GitHub ?..

@AlenJoseph55
Copy link

Hey, Can I do the TODO's in the code?

@bhupal9032
Copy link

i would like to fix this issue.

@Abhi-y2003
Copy link

hey is this issue fixed can you assign me .

@anishlukk123
Copy link

@bhupal. you can work on this

@jaymasiwal
Copy link

hi, I would like to fix this issue as I've very little prior experience with open source can you please help me out with it

@EdmondLee958
Copy link

Hello me and my teammate will be working on this issue.

@Olab23
Copy link

Olab23 commented Aug 15, 2023

I would like to contribute for this project. Can you guys help me out on how to start and proceed with this issue ?

@Klinkaaraa
Copy link

Hello all is there any issue to fix. If so I would like to work on it. Can u guys suggest me??

@Ameerjafar
Copy link

I want to support this project. can somebody assist me in contributing to this project?

@deepakchouhandc
Copy link

I want to support and fix this issue but I don't know who to start.

@DumitruDruta
Copy link

Hello, I want to contribute to this issue. Is it still relevant?

@Klinkaaraa
Copy link

Klinkaaraa commented Dec 5, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests