-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release v0.4.1 failing to compile on ubuntu 16.04 #19
Comments
I tried it and I'm seeing it as well. |
This could be relevant. I'll give it a try and see. |
I can confirm that downgrading bazel to 0.8.1 as suggested in that comment worked for me.
Give this temporary solution a try and let me know if it works. We'll still need to fix this in a more principled way. |
It might not hurt to install a Jenkins server - similar how the protobuf team does it - for continuous integration, as it also plays well with Github PRs and alleviates these simple headaches. |
Installing bazel 0.8.1 fixed the issue for me. It might be worth updating |
The root cause here is that we are cloning a specific version of Tensorflow, while it (and other things) evolved to deal with the Bazel change. Normally, though, we don't want to just clone from TF HEAD because that can break us in other ways. So a fix is to change settings.sh to use a more recent commit, like |
@scott7z Well, my feeling is that would be too much work, which could be fostered elsewhere. Unless there is a defined criteria for working off a specific revision, it is usually less of a benefit to be tied to a specific release. It'll also make the cost of supporting it too much of a headache, as the other dependencies will continue to evolve. I always prefer to simplify and feel it's more practical to push compliance of dependencies to their maintainers, while expanding on the fun part of adding community-driven features. For example, there over 1000 commits between the two SHAs, and it would be hard to keep track of so many contributions: $ git log | grep commit | cat -n | grep '97a4c226e8a9e7c5c36fc38e2b9f8459c77abd5a\|ab0fcaceda001825654424bf18e8a8e0f8d39df2'
1 commit 97a4c226e8a9e7c5c36fc38e2b9f8459c77abd5a
1244 commit ab0fcaceda001825654424bf18e8a8e0f8d39df2
$ Usually more contributions to a dependency might provide us with more opportunities :) |
We pushed a change that pins bazel to 0.8.1. That should take care of things for now. |
Hi,
This is more of a support question, but I wasn't sure where else to get help. I'm trying to build and test deepvariant inside of a docker image. I know that there is already an image published to google cloud, but for my purposes I prefer to build my own image. My docker file looks like this.
The
build_and_test.sh
script fails with these errors:Could anyone shed some light on this issue? Interestingly this was working a few days ago but possibly on a different host. Could it be hardware dependent?
The text was updated successfully, but these errors were encountered: