Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n of page feedback #175

Closed
tobiaskohlbau opened this issue Jan 17, 2020 · 3 comments · Fixed by #1615
Closed

i18n of page feedback #175

tobiaskohlbau opened this issue Jan 17, 2020 · 3 comments · Fixed by #1615
Labels
e0-minutes Effort < 60 min e1-hours enhancement New feature or request p2-medium

Comments

@tobiaskohlbau
Copy link
Contributor

tobiaskohlbau commented Jan 17, 2020 •
edited

Currently the feedback.html partial is not internationalized as the values are hardcoded into English.

docsy/layouts/partials/feedback.html

Lines 17 to 19 in 1b46d71

<p class="feedback--question">Was this page helpful?</p>
<button class="feedback--answer feedback--answer-yes">Yes</button>
<button class="feedback--answer feedback--answer-no">No</button>

I've changed the files in my local repo to resolve this issue. If you the maintainers are happy to accept a PR for this I would like to submit it. If you wanna have a look at the current state see here: tobiaskohlbau@ed57f05
@tobiaskohlbau tobiaskohlbau changed the title add option to translate feedback Add option to translate feedback Jan 17, 2020
@LisaFC
Copy link
Collaborator

LisaFC commented Jan 21, 2020

Oh I really like this - this will be very useful for other Docsy users! Please do submit a PR.

@tobiaskohlbau tobiaskohlbau mentioned this issue Jan 22, 2020
Closed
@LisaFC LisaFC mentioned this issue Apr 28, 2020
Closed
@cjyabraham cjyabraham mentioned this issue Feb 25, 2022
Merged
@chalin chalin changed the title Add option to translate feedback i18n of page feedback Nov 1, 2022
@chalin chalin added enhancement New feature or request e0-minutes Effort < 60 min e1-hours p2-medium labels Nov 1, 2022
@chalin
Copy link
Collaborator

chalin commented Nov 1, 2022

Note that there exist downstream implementations, such as the following:

I'm sure that there are others, I just happened to come across these ones.

@chalin chalin mentioned this issue Nov 1, 2022
Closed
9 tasks
@chalin chalin mentioned this issue Jul 27, 2023
Merged
@chalin
Copy link
Collaborator

chalin commented Jul 27, 2023

@cjyabraham - support has just landed in Docsy (FYI) /cc @nate-double-u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e0-minutes Effort < 60 min e1-hours enhancement New feature or request p2-medium
Projects
None yet
Milestone
No milestone
3 participants
@tobiaskohlbau @chalin @LisaFC