Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume .Site.Copyright is HTML for backwards compatibility #1953

Closed
Tracked by #1812
chalin opened this issue Apr 29, 2024 · 0 comments · Fixed by #1954
Closed
Tracked by #1812

Assume .Site.Copyright is HTML for backwards compatibility #1953

chalin opened this issue Apr 29, 2024 · 0 comments · Fixed by #1954
Milestone
24Q2

Comments

@chalin
Copy link
Collaborator

chalin commented Apr 29, 2024 •
edited

Originally posted by @chalin in #1821 (comment)

Hi @chalin, What’s the rationale behind this change (previously it was {{ with .Site.Copyright }}{{ . | safeHTML }}{{ end }})? I’m worried that it makes it difficult to include HTML badges like the ones generated from https://chooser-beta.creativecommons.org/.

@yann-soubeyrand: My rational was to make processing consistent across alternatives, but it doesn't really need to be consistent -- I can claim backwards compatibility for .Site.Copyright. That is, I'm willing to revert back to the old behavior for .Site.Copyright. How does that sound to you?
@chalin chalin added this to the 24Q2 milestone Apr 29, 2024
This was referenced Apr 29, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q2
Development

Successfully merging a pull request may close this issue.

copyright.html: process .Site.Copyright as HTML chalin/docsy
1 participant
@chalin