Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White Cover Image Becoming Gray #943

Open
snakers4 opened this issue Mar 22, 2022 · 9 comments
Open

White Cover Image Becoming Gray #943

snakers4 opened this issue Mar 22, 2022 · 9 comments
Milestone

Comments

@snakers4
Copy link

Hi,

I am trying customize Docsy by following the standard "happy-path", i.e. just clone the example project and then modify it.

I noticed that if you upload a bright (or white) hero image, it becomes gray, for example:

image

This is displayed when I have a completely white (i.e. #ffffff) hero image uploaded:

featured-background

I cannot find any information about this behaviour, can you please help, this is very frustrating, because I cannot really start making adding real content.

@LukeTimeWalker
Copy link
Contributor

I think this behavior is to prevent the title and heading from becoming "invisible".
If you want to disable this behavior, you can do one of the following options:

  • override /layouts/shortcodes/blocks/cover.html and remove the td-overlay--dark class from the section element
    <section id="{{ $blockID }}" class="row td-cover-block td-cover-block--height-{{ $height }}{{ if not .Site.Params.ui.navbar_translucent_over_cover_disable }} js-td-cover{{ end }} td-overlay td-overlay--dark -bg-{{ $col_id }}">
  • override the styles within /assets/scss/_styles_project.scss (you might create this file first)
.td-overlay--dark::after {
    background-color: transparent;
}

Hope it helps

@snakers4
Copy link
Author

.td-overlay--dark::after {
    background-color: transparent;
}

Many thanks, this works!
Is there any way to make this image not cropped or zoomed, because by default it looks a bit mushy?

@snakers4 snakers4 changed the title White Cover Image Become Gray White Cover Image Becoming Gray Mar 28, 2022
@H20220009
Copy link

Hi, is this issue still open?
I want to work on this issue; please assign me to this.

@chalin
Copy link
Collaborator

chalin commented Feb 11, 2023

@deining - FYI, the steering committee recently clarified that "we don't assign issues in this project. If you would like to contribute, please follow our guidelines." PRs are most welcome, of course. /cc @emckean

@H20220009
Copy link

@emckean @deining @chalin
Can you review the changes and provide any feedback for PR #1491

@H20220009
Copy link

@emckean @chalin @deining
Can you please review the PR #1491 and provide feedback for the same.

@H20220009
Copy link

@emckean @chalin @deining
Can you please review the PR #1491 and provide feedback for the same.

@H20220009
Copy link

@emckean @chalin @deining
Can you please review the PR #1491

1 similar comment
@H20220009
Copy link

@emckean @chalin @deining
Can you please review the PR #1491

@chalin chalin added this to the 23Q3 milestone May 31, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Jul 27, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Nov 3, 2023
@chalin chalin modified the milestones: 24Q1, 24Q2 Jan 11, 2024
@chalin chalin modified the milestones: 24Q2, 24Q3 Apr 2, 2024
@chalin chalin modified the milestones: 24Q3, 24Q4 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants