New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake scripts currently broken? #33

Open
vfxpro99 opened this Issue Aug 2, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@ghost

ghost commented Aug 2, 2016

Doing a checkout at 0e47d5a in January works, however top of tree reports the following, and it is not possible to build with the current cmake scripts.

CMake Error at CMakeLists.txt:44 (install):
install TARGETS given no ARCHIVE DESTINATION for static library target
"double-conversion".

CMake Warning (dev) in CMakeLists.txt:
No cmake_minimum_required command is present. A line of code such as

cmake_minimum_required(VERSION 3.4)

should be added at the top of the file. The version specified may be lower
if you wish to support older CMake versions for this project. For more
information run "cmake --help-policy CMP0000".
This warning is for project developers. Use -Wno-dev to suppress it.

-- Configuring incomplete, errors occurred!

@floitsch

This comment has been minimized.

Collaborator

floitsch commented Aug 13, 2016

I believe the only change in the cmake files were adding GNUIntsallDirs support by @heirecka but I thought that the changes were backwards compatible.

That said, I have no problem bumping the minimal version if that solves the issue. Should we just do that?

@floitsch

This comment has been minimized.

Collaborator

floitsch commented Aug 13, 2016

After having a second look, it's clear to me that bumping the version number won't just do it. (I was looking at the wrong file, and was confused by the error message).

Adding the missing cmake_minimum_required should be trivial. That would get rid of the warning.
The error itself seems to come from the new code that Heiko added. Hopefully he is still active and knows what to do. I will wait a few days to give him time to respond.

@heirecka

This comment has been minimized.

Contributor

heirecka commented Aug 13, 2016

From the warning I and the path of the error message I assume you're not in the root dir of the repo. Also the root CMakeLists.txt has "cmake_minimum_required(VERSION 2.8.12)" which is enough to contain GNUInstallDirs (introduced with 2.8.5).
Not starting in the root dir, doesn't include GNUInstallDirs, which causes the error. It could be added to double-conversion/CMakeLists.txt as well, but I'm not sure this actually works for other reasons.

@markhu

This comment has been minimized.

markhu commented Mar 20, 2017

Using cmake for me only built the *.a file, and no .so file. Is there an implied [or missing] step to build the shared object using CMake?

Here's the last message seen:

Linking CXX static library libdouble-conversion.a
[100%] Built target double-conversion
@heirecka

This comment has been minimized.

Contributor

heirecka commented Apr 1, 2017

Using cmake for me only built the *.a file, and no .so file. Is there an implied [or missing] step to build the shared object using CMake?

-DBUILD_SHARED_LIBS:BOOL=TRUE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment