Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide documentation on draco3d vs draco3dgltf packages? #717

Closed
donmccurdy opened this issue Jun 21, 2021 · 3 comments
Closed

Provide documentation on draco3d vs draco3dgltf packages? #717

donmccurdy opened this issue Jun 21, 2021 · 3 comments
Assignees

Comments

@donmccurdy
Copy link
Contributor

From the information in the README it would be difficult to know that both packages exist, or to know what they each do. I'm still not sure what (if anything) happens if thedraco3d is used to create a glTF file instead of the draco3dgltf package... could the intention for each package be documented?

@tomfinegan
Copy link
Contributor

I think we finally cleared this up:

  • draco3d: all Draco features.
  • draco3dgltf: Only the features of Draco that are included in the Draco GLTF spec.

The build system variable has been renamed, and the help text updated to hopefully help keep this clear in the future. Please feel free to reopen if more discussion or clarification is needed.

@donmccurdy
Copy link
Contributor Author

That's really helpful, thank you! I think if some wording could be added to the draco3dgltf npm package description, particularly emphasizing that it is a subset of the draco3d package, that would be a good clarification. I'd assumed it was a fork with some slightly different behavior, and have seen users assume that it is a superset including functionality related to reading/writing glTF files. Perhaps:

The draco3dgltf package is a subset of the draco3d package, containing only features of the Draco library that are relevant to compression in the glTF file format. glTF files (.gltf, .glb) can contain Draco-compressed mesh geometry, as defined by the glTF extension KHR_draco_mesh_compression.

I might also go one step further and include:

This library does not directly read/write glTF files, but is intended for use within tools and applications that deal with the glTF format. Examples of tools using the Draco library to apply compression to glTF files include: Blender, glTF Transform, and glTF Pipeline.

@tomfinegan
Copy link
Contributor

tomfinegan commented Jan 19, 2022

@donmccurdy The description update will be in the next push. Thanks for the suggested text!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants