Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draco_Transcoder not handling escape characters properly #969

Closed
brian3814 opened this issue Feb 1, 2023 · 3 comments
Closed

Draco_Transcoder not handling escape characters properly #969

brian3814 opened this issue Feb 1, 2023 · 3 comments

Comments

@brian3814
Copy link

brian3814 commented Feb 1, 2023

Hi, I'm trying to compress a glTF model which has node name with escape characters, but it seems to me that the transcoder isn't parsing it correctly.

As shown, the original model can be loaded properly(I'm using three.js editor for testing)
image

Yet, after compressing with the transcoder, three.js editor failed to load the model and return with following error message, which might be caused by unescaped character.

Expected ',' or '}' after property value in JSON at position 207

image

I am wondering if I am missing something or there's actually a false parsing?

Thanks.

compressed_node_with_special_char.zip

node_with_special_char.zip

@brian3814 brian3814 changed the title Draco_Transcoder not handling escape characters properly [bug] Draco_Transcoder not handling escape characters properly Feb 2, 2023
@brian3814 brian3814 changed the title [bug] Draco_Transcoder not handling escape characters properly Draco_Transcoder not handling escape characters properly Feb 2, 2023
@FrankGalligan
Copy link
Collaborator

Thanks for the report. The issue if with the json writing code. We just fixed it internally and will out with the next release. We are currently working on the next please, so that should be out soon.

@brian3814
Copy link
Author

@FrankGalligan Thanks for the support. Looking forward to the next release.

@FrankGalligan
Copy link
Collaborator

@brian3814 We released 1.5.6, which should fix this issue. See more info here https://github.com/google/draco/blob/master/src/draco/io/gltf_utils.h#L155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants