-
Notifications
You must be signed in to change notification settings - Fork 728
/
TimeUnitConversionCheckerTest.java
185 lines (172 loc) · 6.77 KB
/
TimeUnitConversionCheckerTest.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
/*
* Copyright 2018 The Error Prone Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.google.errorprone.bugpatterns.time;
import com.google.errorprone.CompilationTestHelper;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Tests for {@link TimeUnitConversionChecker}. */
@RunWith(JUnit4.class)
public class TimeUnitConversionCheckerTest {
private final CompilationTestHelper helper =
CompilationTestHelper.newInstance(TimeUnitConversionChecker.class, getClass());
@Test
public void literalConvertToSelf() {
helper
.addSourceLines(
"TestClass.java",
"import java.util.concurrent.TimeUnit;",
"public class TestClass {",
" // BUG: Diagnostic contains: private long value = 42L /* milliseconds */;",
" private long value = TimeUnit.MILLISECONDS.toMillis(42);",
"}")
.doTest();
}
@Test
public void literalConvertToSelf_withStaticImport() {
helper
.addSourceLines(
"TestClass.java",
"import static java.util.concurrent.TimeUnit.MILLISECONDS;",
"public class TestClass {",
" // BUG: Diagnostic contains: private long value = 42L /* milliseconds */;",
" private long value = MILLISECONDS.toMillis(42);",
"}")
.doTest();
}
@Test
public void variableConvertToSelf_withStaticImport() {
helper
.addSourceLines(
"TestClass.java",
"import static java.util.concurrent.TimeUnit.MILLISECONDS;",
"public class TestClass {",
" private long toConvert = 42;",
" // BUG: Diagnostic contains: private long value = toConvert /* milliseconds */;",
" private long value = MILLISECONDS.toMillis(toConvert);",
"}")
.doTest();
}
@Test
public void expressionEvaluatesToZero() {
helper
.addSourceLines(
"TestClass.java",
"import java.util.concurrent.TimeUnit;",
"public class TestClass {",
" // BUG: Diagnostic contains: private static final long VALUE1 = 0L /* seconds */;",
" private static final long VALUE1 = TimeUnit.MILLISECONDS.toSeconds(4);",
" // BUG: Diagnostic contains: private static final long VALUE2 = 0L /* seconds */;",
" private static final long VALUE2 = TimeUnit.MILLISECONDS.toSeconds(400);",
"}")
.doTest();
}
@Test
public void expressionEvaluatesToZero_withStaticImport() {
helper
.addSourceLines(
"TestClass.java",
"import static java.util.concurrent.TimeUnit.MILLISECONDS;",
"public class TestClass {",
" // BUG: Diagnostic contains: private static final long VALUE1 = 0L /* seconds */;",
" private static final long VALUE1 = MILLISECONDS.toSeconds(4);",
" // BUG: Diagnostic contains: private static final long VALUE2 = 0L /* seconds */;",
" private static final long VALUE2 = MILLISECONDS.toSeconds(400);",
"}")
.doTest();
}
@Test
public void expressionEvaluatesToOne() {
helper
.addSourceLines(
"TestClass.java",
"import java.util.concurrent.TimeUnit;",
"public class TestClass {",
" // BUG: Diagnostic contains: private static final long VALUE1 = 1L /* seconds */;",
" private static final long VALUE1 = TimeUnit.MILLISECONDS.toSeconds(1000);",
" // BUG: Diagnostic contains: private static final long VALUE2 = 1L /* seconds */;",
" private static final long VALUE2 = TimeUnit.MILLISECONDS.toSeconds(1999);",
"}")
.doTest();
}
@Test
public void expressionEvaluatesToNegativeOne() {
helper
.addSourceLines(
"TestClass.java",
"import java.util.concurrent.TimeUnit;",
"public class TestClass {",
" // BUG: Diagnostic contains: TimeUnitConversionChecker",
" private static final long VALUE1 = TimeUnit.MILLISECONDS.toSeconds(-1000);",
" // BUG: Diagnostic contains: TimeUnitConversionChecker",
" private static final long VALUE2 = TimeUnit.MILLISECONDS.toSeconds(-1999);",
"}")
.doTest();
}
@Test
public void expressionEvaluatesToLargeNumber() {
helper
.addSourceLines(
"TestClass.java",
"import java.util.concurrent.TimeUnit;",
"public class TestClass {",
" // BUG: Diagnostic contains: TimeUnitConversionChecker",
" private static final long VALUE1 = TimeUnit.MILLISECONDS.toSeconds(4321);",
" // BUG: Diagnostic contains: TimeUnitConversionChecker",
" private static final long VALUE2 = TimeUnit.MILLISECONDS.toSeconds(-4321);",
"}")
.doTest();
}
@Test
public void expressionEvaluatesToLargeNumber_withStaticImport() {
helper
.addSourceLines(
"TestClass.java",
"import static java.util.concurrent.TimeUnit.MILLISECONDS;",
"public class TestClass {",
" // BUG: Diagnostic contains: TimeUnitConversionChecker",
" private static final long VALUE1 = MILLISECONDS.toSeconds(4321);",
" // BUG: Diagnostic contains: TimeUnitConversionChecker",
" private static final long VALUE2 = MILLISECONDS.toSeconds(-4321);",
"}")
.doTest();
}
@Test
public void largeUnitToSmallUnit_succeeds() {
helper
.addSourceLines(
"TestClass.java",
"import static java.util.concurrent.TimeUnit.SECONDS;",
"public class TestClass {",
" private static final long VALUE1 = SECONDS.toMillis(4321);",
" private static final long VALUE2 = SECONDS.toMillis(-4321);",
"}")
.doTest();
}
@Test
public void receiverExpression() {
helper
.addSourceLines(
"TestClass.java",
"import java.util.concurrent.TimeUnit;",
"public class TestClass {",
" long f(TimeUnit timeUnit, long time) {",
" return (timeUnit != null ? timeUnit : TimeUnit.MILLISECONDS).toMillis(time);",
" }",
"}")
.doTest();
}
}