Skip to content

Commit

Permalink
Fix typo
Browse files Browse the repository at this point in the history
MOE_MIGRATED_REVID=124150059
  • Loading branch information
cushon committed Jun 7, 2016
1 parent 9c5abbd commit 2ff1e07
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 29 deletions.
Expand Up @@ -35,13 +35,13 @@
* @author bhagwani@google.com (Sumit Bhagwani) * @author bhagwani@google.com (Sumit Bhagwani)
*/ */
@BugPattern( @BugPattern(
name = "SelfComparision", name = "SelfComparison",
summary = "An object is compared to itself", summary = "An object is compared to itself",
category = JDK, category = JDK,
severity = ERROR, severity = ERROR,
maturity = MATURE maturity = MATURE
) )
public class SelfComparision extends BugChecker implements MethodInvocationTreeMatcher { public class SelfComparison extends BugChecker implements MethodInvocationTreeMatcher {


/** /**
* Matches calls to any instance method called "compareTo" with exactly one argument in which the * Matches calls to any instance method called "compareTo" with exactly one argument in which the
Expand Down
Expand Up @@ -106,7 +106,7 @@
import com.google.errorprone.bugpatterns.RestrictedApiChecker; import com.google.errorprone.bugpatterns.RestrictedApiChecker;
import com.google.errorprone.bugpatterns.ReturnValueIgnored; import com.google.errorprone.bugpatterns.ReturnValueIgnored;
import com.google.errorprone.bugpatterns.SelfAssignment; import com.google.errorprone.bugpatterns.SelfAssignment;
import com.google.errorprone.bugpatterns.SelfComparision; import com.google.errorprone.bugpatterns.SelfComparison;
import com.google.errorprone.bugpatterns.SelfEquality; import com.google.errorprone.bugpatterns.SelfEquality;
import com.google.errorprone.bugpatterns.SelfEquals; import com.google.errorprone.bugpatterns.SelfEquals;
import com.google.errorprone.bugpatterns.SizeGreaterThanOrEqualsZero; import com.google.errorprone.bugpatterns.SizeGreaterThanOrEqualsZero;
Expand Down Expand Up @@ -343,7 +343,7 @@ public static ScannerSupplier errorChecks() {
RemoveUnusedImports.class, RemoveUnusedImports.class,
ScopeAnnotationOnInterfaceOrAbstractClass.class, ScopeAnnotationOnInterfaceOrAbstractClass.class,
ScopeOrQualifierAnnotationRetention.class, ScopeOrQualifierAnnotationRetention.class,
SelfComparision.class, SelfComparison.class,
SelfEquality.class, SelfEquality.class,
SelfEquals.class, SelfEquals.class,
StaticAccessedFromInstance.class, StaticAccessedFromInstance.class,
Expand Down
Expand Up @@ -24,25 +24,25 @@
import org.junit.runners.JUnit4; import org.junit.runners.JUnit4;


/** /**
* Unit tests for {@link SelfComparision} bug pattern. * Unit tests for {@link SelfComparison} bug pattern.
* @author bhagwani@google.com (Sumit Bhagwani) * @author bhagwani@google.com (Sumit Bhagwani)
*/ */
@RunWith(JUnit4.class) @RunWith(JUnit4.class)
public class SelfComparisionTest { public class SelfComparisonTest {
CompilationTestHelper compilationHelper; CompilationTestHelper compilationHelper;


@Before @Before
public void setUp() { public void setUp() {
compilationHelper = CompilationTestHelper.newInstance(SelfComparision.class, getClass()); compilationHelper = CompilationTestHelper.newInstance(SelfComparison.class, getClass());
} }


@Test @Test
public void testPositiveCase() throws Exception { public void testPositiveCase() throws Exception {
compilationHelper.addSourceFile("SelfComparisionPositiveCase.java").doTest(); compilationHelper.addSourceFile("SelfComparisonPositiveCase.java").doTest();
} }


@Test @Test
public void testNegativeCase() throws Exception { public void testNegativeCase() throws Exception {
compilationHelper.addSourceFile("SelfComparisionNegativeCases.java").doTest(); compilationHelper.addSourceFile("SelfComparisonNegativeCases.java").doTest();
} }
} }
Expand Up @@ -17,37 +17,37 @@
package com.google.errorprone.bugpatterns; package com.google.errorprone.bugpatterns;


/** /**
* Negative test cases for {@link SelfComparision} check. * Negative test cases for {@link SelfComparison} check.
* @author bhagwani@google.com (Sumit Bhagwani) * @author bhagwani@google.com (Sumit Bhagwani)
*/ */
public class SelfComparisionNegativeCases implements Comparable<Object> { public class SelfComparisonNegativeCases implements Comparable<Object> {
private String field; private String field;


@Override @Override
public int hashCode() { public int hashCode() {
return field != null ? field.hashCode() : 0; return field != null ? field.hashCode() : 0;
} }

@Override @Override
public int compareTo(Object o) { public int compareTo(Object o) {
if (!(o instanceof SelfComparisionNegativeCases)) { if (!(o instanceof SelfComparisonNegativeCases)) {
return -1; return -1;
} }

SelfComparisionNegativeCases other = (SelfComparisionNegativeCases) o; SelfComparisonNegativeCases other = (SelfComparisonNegativeCases) o;
return field.compareTo(other.field); return field.compareTo(other.field);
} }

public int test() { public int test() {
return Boolean.TRUE.toString().compareTo(Boolean.FALSE.toString()); return Boolean.TRUE.toString().compareTo(Boolean.FALSE.toString());
} }


public static class ComparisionTest implements Comparable<ComparisionTest> { public static class CopmarisonTest implements Comparable<CopmarisonTest> {
private String testField; private String testField;

@Override @Override
public int compareTo(ComparisionTest obj) { public int compareTo(CopmarisonTest obj) {
return testField.compareTo(obj.testField); return testField.compareTo(obj.testField);
} }
} }

} }
Expand Up @@ -17,18 +17,19 @@
package com.google.errorprone.bugpatterns; package com.google.errorprone.bugpatterns;


/** /**
* Positive test case for {@link SelfComparision} check. * Positive test case for {@link SelfComparison} check.
* @author bhagwani@google.com (Sumit Bhagwani) * @author bhagwani@google.com (Sumit Bhagwani)
*/ */
public class SelfComparisionPositiveCase implements Comparable<Object> { public class SelfComparisonPositiveCase implements Comparable<Object> {

public int test1() { public int test1() {
SelfComparisionPositiveCase obj = new SelfComparisionPositiveCase(); SelfComparisonPositiveCase obj = new SelfComparisonPositiveCase();
// BUG: Diagnostic contains: An object is compared to itself // BUG: Diagnostic contains: An object is compared to itself
return obj.compareTo(obj); return obj.compareTo(obj);
} }


private SelfComparisionPositiveCase obj = new SelfComparisionPositiveCase(); private SelfComparisonPositiveCase obj = new SelfComparisonPositiveCase();

public int test2() { public int test2() {
// BUG: Diagnostic contains: An object is compared to itself // BUG: Diagnostic contains: An object is compared to itself
return obj.compareTo(this.obj); return obj.compareTo(this.obj);
Expand All @@ -54,20 +55,22 @@ public int compareTo(Object o) {
return 0; return 0;
} }


public static class ComparisionTest implements Comparable<ComparisionTest> { public static class ComparisonTest implements Comparable<ComparisonTest> {
private String testField; private String testField;

@Override @Override
public int compareTo(ComparisionTest s) { public int compareTo(ComparisonTest s) {
return testField.compareTo(s.testField); return testField.compareTo(s.testField);
} }


public int test1() { public int test1() {
ComparisionTest obj = new ComparisionTest(); ComparisonTest obj = new ComparisonTest();
// BUG: Diagnostic contains: An object is compared to itself // BUG: Diagnostic contains: An object is compared to itself
return obj.compareTo(obj); return obj.compareTo(obj);
} }


private ComparisionTest obj = new ComparisionTest(); private ComparisonTest obj = new ComparisonTest();

public int test2() { public int test2() {
// BUG: Diagnostic contains: An object is compared to itself // BUG: Diagnostic contains: An object is compared to itself
return obj.compareTo(this.obj); return obj.compareTo(this.obj);
Expand Down
File renamed without changes.

0 comments on commit 2ff1e07

Please sign in to comment.