Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review request #29

Closed
cushon opened this issue Oct 31, 2014 · 2 comments
Closed

Code review request #29

cushon opened this issue Oct 31, 2014 · 2 comments
Labels
migrated Priority-Medium Status-Done Type-Review

Comments

@cushon
Copy link
Collaborator

cushon commented Oct 31, 2014

Original issue created by eaftan@google.com on 2012-07-26 at 09:54 PM

Please take a look at my 3 commits from today (7/26). I reworked ErrorReportingJavaCompiler to scan compilation units all at once, so that file-level nodes like imports and package declarations are scanned.
@cushon
Copy link
Collaborator Author

cushon commented Oct 31, 2014

Original comment posted by eaftan@google.com on 2012-07-30 at 05:23 PM

Alex, any chance you could take a look at this today?

@cushon
Copy link
Collaborator Author

cushon commented Oct 31, 2014

Original comment posted by alexeagle@google.com on 2012-07-30 at 06:27 PM

Maybe I should review them in some other order so I don't make comments just to find the next revision already addresses them...

Status: Done

@cushon cushon closed this as completed Oct 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
migrated Priority-Medium Status-Done Type-Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cushon