Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot-location rule should be configured as ['error', 'object'] #22

Closed
kazarmy opened this issue Sep 16, 2016 · 1 comment
Closed

dot-location rule should be configured as ['error', 'object'] #22

kazarmy opened this issue Sep 16, 2016 · 1 comment

Comments

@kazarmy
Copy link

kazarmy commented Sep 16, 2016

The Google Style Guide states that for dot operators in multiline expressions, the dot operator should be on the preceding line:

var x = foo.bar().
    doSomething().
    doSomethingElse();

However, xo configures the dot-location rule as:

'dot-location': ['error', 'property']

which mandates that the dot operator be on the following line. This should be overriden by eslint-config-google as follows:

'dot-location': ['error', 'object']
@kazarmy
Copy link
Author

kazarmy commented Sep 25, 2016

Closing due to PR #23.

@kazarmy kazarmy closed this as completed Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant