Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying the meaning of "weight" #12

Closed
Saipraneet opened this issue Jan 13, 2021 · 1 comment
Closed

Clarifying the meaning of "weight" #12

Saipraneet opened this issue Jan 13, 2021 · 1 comment

Comments

@Saipraneet
Copy link

In the Intro notebook, the backward_pass_output from model.backward has a weight feature.
It seems to me that this is used for performing a weighted averaging in FedAvg, but this is not clear to me how. Perhaps this can be renamed to batch_size?

@jaehunro
Copy link
Collaborator

Valid point. Thanks for letting us know! I just merged #15 which renames weight in both BackwardPassOutput and ClientTrainerState to num_examples instead. We chose not to use batch_size because the definition is a bit too restrictive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants