Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hiveJdbcDriver configuration property and unify driver loading #713

Closed
bashir2 opened this issue May 25, 2023 · 0 comments · Fixed by #811
Closed

Remove hiveJdbcDriver configuration property and unify driver loading #713

bashir2 opened this issue May 25, 2023 · 0 comments · Fixed by #811
Assignees
@bashir2
Labels
enhancement New feature or request P2:should An issue to be addressed in a quarter or so.

Comments

@bashir2
Copy link
Collaborator

bashir2 commented May 25, 2023

We moved the driver class into the DB config.json file in this PR #679 but we still have the hiveJdbcDriver in DataProperties class here which should be removed.

We also have to unify how we use JDBC drivers. For hive2 we use DriverManager here which automatically finds the driver class from the JDBC URL. But in JdbcConnectionPools we explicitly set the driver here.
@bashir2 bashir2 added enhancement New feature or request P2:should An issue to be addressed in a quarter or so. labels May 25, 2023
@bashir2 bashir2 mentioned this issue May 25, 2023
Merged
7 tasks
@bashir2 bashir2 self-assigned this Jul 25, 2023
@bashir2 bashir2 mentioned this issue Sep 12, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bashir2 bashir2

Labels
enhancement New feature or request P2:should An issue to be addressed in a quarter or so.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes hiveJdbcDriver configuration parameter. bashir2/openmrs-fhir-analytics
1 participant
@bashir2