Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ViewDefinition support to incremental updates plus a fast recreate option for views #916

Closed
bashir2 opened this issue Jan 9, 2024 · 1 comment · Fixed by #929
Closed
Assignees
Labels
enhancement New feature or request P1:must As issue that definitely needs to be implemented in near future.

Comments

@bashir2
Copy link
Collaborator

bashir2 commented Jan 9, 2024

After #821 and #822 we can convert FHIR resources to flat views and write them to any relational DB using SQL-on-FHIR-v2 ViewDefinition resources. We should add this to the periodic/incremental updates too (in controller logic). To do this, each view row should always have the unique ID of the original resource such that the corresponding rows can be updated when a FHIR resources is updated (or deleted).

@bashir2 bashir2 self-assigned this Jan 9, 2024
@bashir2 bashir2 added enhancement New feature or request P1:must As issue that definitely needs to be implemented in near future. labels Jan 9, 2024
@bashir2 bashir2 changed the title Add ViewDefinition support to incremental updates Add ViewDefinition support to incremental updates plus a fast recreate option for views Jan 27, 2024
@bashir2
Copy link
Collaborator Author

bashir2 commented Jan 27, 2024

Note the scope of this issue was widened to include a fast option for recreating views. The idea is that if a ViewDefinition is modified or added, we can recreate the views by just reading the data-warehouse snapshot (i.e., the Parquet files) without refetching the resources from the FHIR server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1:must As issue that definitely needs to be implemented in near future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant