Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate the changes done by ONA to the forked FHIR Gateway server component #109

Closed
vivekmittal07 opened this issue Feb 22, 2023 · 4 comments
Closed

Evaluate the changes done by ONA to the forked FHIR Gateway server component #109

vivekmittal07 opened this issue Feb 22, 2023 · 4 comments
Assignees
@vivekmittal07
Milestone
Beta launch

Comments

@vivekmittal07
Copy link
Collaborator

Parent Issue - #108
@vivekmittal07 vivekmittal07 self-assigned this Feb 22, 2023
@vivekmittal07 vivekmittal07 added this to the Beta launch milestone Feb 23, 2023
@vivekmittal07
Copy link
Collaborator Author

vivekmittal07 commented Feb 23, 2023 •
edited

Changes done in the forked repo

  1. Skip token verification for allowed queries - opensrp@55bb437
  2. Modify Allowed queries checker to support path variables and method type validation - opensrp@55bb437
  3. Resource finder utility for processing bundles.
  4. Enable preprocessing of request for an access decision - opensrp@09584ef.
  5. Plugin specific Proxy constants.

5 is not needed in the server and can be easily moved to the plugin code.

@dubdabasoduba
Copy link
Contributor

@vivekmittal07 4 has some OpenSRP-specific classes we might want to refactor that.

@dubdabasoduba
Copy link
Contributor

The rest is correct

@vivekmittal07
Copy link
Collaborator Author

Thanks Benjamin!

I realised now why preprocess stage was introduced.
I have created this to allow request mutation in the access checker design - #122

@bashir2 bashir2 mentioned this issue Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vivekmittal07 vivekmittal07

Labels
None yet
Projects
None yet
Milestone
Beta launch
Development

No branches or pull requests
2 participants
@dubdabasoduba @vivekmittal07