Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SMART-on-FHIR scopes #41

Closed
bashir2 opened this issue Dec 17, 2022 · 4 comments · Fixed by #89
Closed

Add support for SMART-on-FHIR scopes #41

bashir2 opened this issue Dec 17, 2022 · 4 comments · Fixed by #89
Assignees
@anchita-g
Labels
enhancement New feature or request Mid-March Check-up P1:must As issue that definitely needs to be implemented in near future.
Milestone
Mid-March Check-up

Comments

@bashir2
Copy link
Collaborator

bashir2 commented Dec 17, 2022

Currently in PatientAccessChecker we do not apply the SoF scope constraints. We need to support patient/*.* scopes as this AccessChecker is intended to honor patient launch/scopes scenarios in the SoF spec.
@bashir2 bashir2 added enhancement New feature or request P3:TBE An issue that is not evaluated and/or planned for implementation yet. labels Dec 17, 2022
@bashir2 bashir2 added P2:should An issue to be addressed in a quarter or so. and removed P3:TBE An issue that is not evaluated and/or planned for implementation yet. labels Jan 11, 2023
@bashir2 bashir2 added P1:must As issue that definitely needs to be implemented in near future. and removed P2:should An issue to be addressed in a quarter or so. labels Jan 30, 2023
@anchita-g anchita-g mentioned this issue Feb 3, 2023
Merged
7 tasks
@yeswanthsubramanian yeswanthsubramanian mentioned this issue Feb 22, 2023
Open
@bashir2 bashir2 added this to the Beta launch milestone Feb 22, 2023
@jjtswan
Copy link
Collaborator

jjtswan commented Mar 3, 2023

Can we get a quick status check on this? For some reason in the project it's listed as "done", but the issue itself is still "Open".

Was there an associated PR?

@jjtswan
Copy link
Collaborator

jjtswan commented Mar 3, 2023

[Moving this back to "In progress"]

@jjtswan
Copy link
Collaborator

jjtswan commented Mar 3, 2023 •
edited
Loading

Ah hah. I can see #89 , so perhaps this did get fixed?

Anchita or Bashir, can you confirm? Also, does this mean that we have a demo of a smart-on-fhir app working? If so, that might make a great presentation / demo to the team.

@jjtswan jjtswan linked a pull request Mar 3, 2023 that will close this issue
Supporting SMART on FHIR patient scopes in PatientAccessChecker #89
Merged
7 tasks
@bashir2
Copy link
Collaborator Author

bashir2 commented Mar 6, 2023

Yes, I thinks #89 fixed this.

@bashir2 bashir2 closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anchita-g anchita-g

Labels
enhancement New feature or request Mid-March Check-up P1:must As issue that definitely needs to be implemented in near future.
Projects
None yet
Milestone
Mid-March Check-up
Development

Successfully merging a pull request may close this issue.

Supporting SMART on FHIR patient scopes in PatientAccessChecker anchita-g/fhir-access-proxy
4 participants
@bashir2 @jjtswan @anchita-g @yeswanthsubramanian