Get rid of BuildError and adopt solution from Gin, which uses subclassing to attach some additional error information. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_480975837
branch
5 times, most recently
from
aba3d84
to
e870c45
Compare
copybara-service
bot
force-pushed
the
test_480975837
branch
from
e870c45
to
e8c5780
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_480975837
branch
6 times, most recently
from
595509a
to
b55e4f4
Compare
copybara-service
bot
force-pushed
the
test_480975837
branch
from
b55e4f4
to
a4be791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of BuildError and adopt solution from Gin, which uses subclassing to attach some additional error information.
We have chosen to go with this slightly magical approach, since the stack traces from Python's
raise new_error from old_errorfeature shows the user Fiddle internal stack trace lines first, even when the error is clearly from user code.