Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Python3.8 Support #492

Closed
ppwwyyxx opened this issue Sep 16, 2023 · 4 comments
Closed

Keep Python3.8 Support #492

ppwwyyxx opened this issue Sep 16, 2023 · 4 comments

Comments

@ppwwyyxx
Copy link
Contributor

Python3.8 support was dropped in 6651b61. We would really want it back.

According to https://pypistats.org/packages/jax, Python3.8 has a very large user base among jax users:
2023-09-16_04-03

I use fiddle with PyTorch not jax, and 3.8 is still the most popular python version among its users:
2023-09-16_04-06

Although jax has dropped 3.8 support recently, the above pictures suggest that many of the ML community are using 3.8, therefore it's better if the ecosystem around it can support 3.8 for a little longer.

@vufg

@panzhufeng
Copy link
Collaborator

Thanks for bring this up! Discussing this with the team and will get back to you shortly

@panzhufeng
Copy link
Collaborator

Hi there, the team agree we should continue Python 3.8 support. There are some Fiddle tests fail under python 3.8 at the moment. I'm working on the fix and will send a PR shortly.

@ppwwyyxx
Copy link
Contributor Author

Thanks a lot!

@panzhufeng
Copy link
Collaborator

added Python 3.8 support back in 971eaa8. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants