window10 build release branch failed

[wolfand11]

Describe the bug
build release branch failed

To Reproduce
Steps to reproduce the behavior:

1. cd d:/Documents/MyProject/Public/Graphics/filament/
2. git clone -b release https://github.com/google/filament.git ./
3. mkdir out
4. cd out
5. cmake ..
   error message ： CMake Error at third_party/glslang/tnt/CMakeLists.txt:96 (list):
   list GET given empty list

Expected behavior
build success

Screenshots

Desktop (please complete the following information):

• OS: Windows10
• GPU: NVIDIA GTX 1050
• Backend: OpenGL
• CMake version: 3.20.5

[wolfand11]

i tried main branch and rc/1.10.7 , failed too.

[prideout]

I think the build_info.py script in glslang is erroring out, so the GLSLANG_VERSIONS variable in the CMake is empty.

[bejado]

What version of CMake are you using?

[wolfand11]

@bejado cmake version is 3.20.5

[bejado]

Seems like this is a Python-related problem. I recommend filing an issue directly with glslang.

[wolfand11]

@bejado i clone and build glslang. it's success. thanks for any help. i'm not good at cmake. can't find any issue.

build glslang sucess.

[bejado]

I'm not sure why this isn't working for you, but I notice that our glslang CMakeLists.txt is out-of-date. For example, they no longer use Python to retrieve the GLSLANG version: KhronosGroup/glslang@05798c1.

I'll update our CMakeLists.txt, which hopefully will fix the issue for you.

[romainguy]

@bejado Can we update glslang while we're at it?

[bejado]

@romainguy I think we just did, but not the CMakeLists.txt.

[prideout]

Thanks for looking into this Ben, it's my fault, when I updated glslang I didn't notice this detail.