Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file Dart 2 compatible. #103

Closed
pq opened this issue Aug 10, 2018 · 1 comment
Closed

Make file Dart 2 compatible. #103

pq opened this issue Aug 10, 2018 · 1 comment

Comments

@pq
Copy link
Collaborator

pq commented Aug 10, 2018

file tests fail due to type errors of the familiar

type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, String>' of 'input'

variety.

See: https://travis-ci.org/google/file.dart/jobs/414381120

A few changes get us most of the way there:

PathContextCodec =>

static path.Context _decode(Map<String, dynamic> input) {

and

static const Converter<Map<String, dynamic>, path.Context> deserialize =
      const _ForwardingConverter<Map<String, dynamic>, path.Context>(_decode);

but someone who understands the source should look a little closer.

/cc @tvolkert ?

@tvolkert
Copy link
Collaborator

Dup of #88?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants