Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parsing json with quote #41

Closed
dyu opened this issue Jul 25, 2014 · 3 comments
Closed

Allow parsing json with quote #41

dyu opened this issue Jul 25, 2014 · 3 comments

Comments

@dyu
Copy link
Contributor

dyu commented Jul 25, 2014

Currently, GeneratorOptions.strict_json allows serializing fields with quotes.
Parser.Parse fails when the json source contains fields with quotes.

@ghost
Copy link

ghost commented Jul 25, 2014

Thanks, will fix.

@ghost
Copy link

ghost commented Jul 25, 2014

Just looked, but this was already in the current code. I can write field names with quotes. Anything in particular that's not working?

@dyu
Copy link
Contributor Author

dyu commented Jul 26, 2014

Sorry, false alarm. I edited test/monsterdata_test.golden and quoted the fields, which gave errors when running flattests (I assumed it was the parser that balked).
Turns out, I had to add this line in ParseAndGenerateTextTest for the equality test:
opts.strict_json = true;

@dyu dyu closed this as completed Jul 26, 2014
kakikubo pushed a commit to kakikubo/flatbuffers that referenced this issue Apr 19, 2016
…ign_resize

support to resize vector when assigning value (require default value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant